Fix seasonal foliage colors in Distant Horizons #571
Conversation
|
I can't really speak to the details of the code since I mostly handle design stuff, but I feel like just having a hardcoded list of blocks that use foliage/grass coloring probably isn't the best idea? There are plenty of modded blocks that use foliage/grass coloring, including a good handful from Biomes O' Plenty (One of our other mods, so compatibility is important). If it's possible to use block tags for this, that would be better, or if there's some way to actually retrieve what blocks are registered to use grass/foliage coloring, that would be even more ideal (I doubt there is though). |
|
I will definitely look into improving the implementation. After further testing I've found some bugs with jungle and acacia biomes with my fix, will patch and update PR tomorrow |
|
Tried to fix tropical biomes in DH chunks today but no luck, giving me a hard time. Will keep trying later. |
|
I ran out of time working on other stuff this weekend, this patch is first on my list this upcoming week though, determined to get it working lol |
|
Made some progress today on this, but still not 100%. Will continue working |
2 participants
Problem: Distant Horizons only queried per-block color handlers. Serene Seasons only registered one for birch leaves, relying on biome color resolvers for everything else. DH therefore rendered oak leaves and grass with vanilla colors outside the main render distance.
Root Cause: Missing block color registrations for seasonal-tinted foliage/grass, while birch had a dedicated handler.
Fix: Added reusable SeasonColorHandlers.getSeasonalColor APIs so other callers can obtain seasonal colors without duplicating resolver logic.
Registered block color callbacks for all foliage/grass blocks, delegating to SeasonColorHandlers and falling back gracefully when context is absent.
Result: Distant Horizons LODs now receive the same seasonal tint data as birch leaves, keeping grass and other leaves visually consistent at any distance.