Login & automatic membership system by mfaalk · Pull Request #108 · Glennmen/PMSF

mfaalk · 2018-03-26T16:59:26Z

MOVED TO PR #109

[WIP] Roadmap 1

Merge latest develop changes into master

hammydown4325 · 2018-03-26T18:28:19Z

+            $passwordErr = '';
+            $password = $_POST["password"];
+
+            if (strlen($_POST["password"]) <= '5') {


Doesnt make sense. Says Less than or equal to 5 and the error says 8?

Solved. Forgot to update the error message. Min character set to 6.

hammydown4325 · 2018-03-26T18:30:18Z

+				<center>
+					<button class="settings"
+							onclick="document.location.href='logout.php'">
+						<i class="fa" aria-hidden="true"></i> Logout


Needs to be translatable

hammydown4325 · 2018-03-26T18:30:40Z

+
+                    echo $_SESSION['user']->email . "<br>";
+                    if ($_SESSION['user']->expire_timestamp > time()) {
+                        echo "<span style='color: green;'>Account expires on {$time}</span>";


Needs to be translatable

hammydown4325 · 2018-03-26T18:30:44Z

+                    if ($_SESSION['user']->expire_timestamp > time()) {
+                        echo "<span style='color: green;'>Account expires on {$time}</span>";
+                    } else {
+                        echo "<span style='color: green;'>Account expired on {$time}</span>";


Needs to be translatable

hammydown4325

Initial Review. More to come

hammydown4325 · 2018-03-26T18:31:03Z

+            } elseif (!preg_match("#[A-Z]#", $password)) {
+                $passwordErr = "<b>Your password must contain at least 1 capital letter!</b><br>";
+            } elseif (!preg_match("#[a-z]#", $password)) {
+                $passwordErr = "<b>Your password must contain at least 1 lowercase letter!</b><br>";


Needs to be translatable

hammydown4325 · 2018-03-26T18:31:07Z

+            } elseif (!preg_match("#[0-9]#", $password)) {
+                $passwordErr = "<b>Your password must contain at least 1 number!</b><br>";
+            } elseif (!preg_match("#[A-Z]#", $password)) {
+                $passwordErr = "<b>Your password must contain at least 1 capital letter!</b><br>";


Needs to be translatable

hammydown4325 · 2018-03-26T18:31:39Z

+            $password = $_POST["password"];
+
+            if (strlen($_POST["password"]) <= '5') {
+                $passwordErr = "<b>Your password must contain at least 8 characters!</b><br>";


Needs to be translatable

hammydown4325 · 2018-03-26T18:31:44Z

+            if (strlen($_POST["password"]) <= '5') {
+                $passwordErr = "<b>Your password must contain at least 8 characters!</b><br>";
+            } elseif (!preg_match("#[0-9]#", $password)) {
+                $passwordErr = "<b>Your password must contain at least 1 number!</b><br>";


Needs to be translatable

hammydown4325 · 2018-03-26T18:31:55Z

+                $passwordErr = "<b>Your password must contain at least 1 lowercase letter!</b><br>";
+            }
+        } else {
+            $passwordErr = "<b>Your passwords didn't match!</b><br>";


Needs to be translatable

hammydown4325 · 2018-03-26T18:32:14Z

+                die();
+            }
+        } else {
+            echo "Incorrect username or password.";


Needs to be translatable

hammydown4325 · 2018-03-26T18:32:22Z

+		<form action='' method='POST'>
+			<table>
+				<tr>
+					<th>New password</th><td><input type="password" name="password" required></td>


Needs to be translatable

hammydown4325 · 2018-03-26T18:32:28Z

+					<th>New password</th><td><input type="password" name="password" required></td>
+				</tr>
+				<tr>
+					<th>Confirm password</th><td><input type="password" name="repassword" required></td>


Needs to be translatable

hammydown4325 · 2018-03-26T18:32:34Z

+		<form action='' method='POST'>
+			<table>
+				<tr>
+					<th>E-mail</th><td><input type="text" name="email" required></td>


Needs to be translatable

hammydown4325 · 2018-03-26T18:32:38Z

+					<th>E-mail</th><td><input type="text" name="email" required></td>
+				</tr>
+				<tr>
+					<th>Password</th><td><input type="password" name="password" required></td>


Needs to be translatable

Glennmen · 2018-03-27T08:18:24Z

I see you are using SHA1, wouldn't it be better to use something more secure?

mfaalk · 2018-03-27T08:37:53Z

Sure. I haven't done much web development in a couple of years so I just did a quick google search and found sha1.
password_hash may be more interesting?

Also, I haven't added anything for sql injections, I figured the framework would take care of that?

Glennmen · 2018-03-27T09:12:50Z

@mfaalk PHP docs have lots of info: http://php.net/manual/en/function.password-hash.php

You mean the Medoo framework? If you use the prepared statements then it should.

mfaalk · 2018-04-04T18:09:44Z

I messed up.
Opening a second PR.

Glennmen and others added 21 commits February 19, 2018 09:29

Merge pull request #35 from Glennmen/develop

5ea1852

[WIP] Roadmap 1

Merge pull request #107 from Glennmen/develop

d448786

Merge latest develop changes into master

[add]Simple login form and js login check

833cfe6

[fix]removed old code

7cd9984

[add]Webhook, change password

9cf6a99

[add]enable or disable login from config

fa226a0

[add]show expire date on home page

0a38249

[add]move salt to config file

ab35fc2

[add]logout button and user info

41505c3

[add]logout.php

6ba7ef5

[fix]Stop it travis :-(

c9fddaa

[fix]Stop it travis 2 :-(

5cc7e4e

[fix]Stop it travis 3 :-(

79f151b

[fix]styleci? ^_^

e8d25aa

[fix]styleci pls

1156cff

[fix]pre-index, wh plus sign

32e2d90

[fix]wh plus sign

1a1d146

[fix]wh plus sign

ca1d738

[fix]styleci

416be1e

[fix]wh plus sign

79c4ac6

[fix]more plus signs

8d351bc

hammydown4325 reviewed Mar 26, 2018

View reviewed changes

mfaalk added 4 commits March 26, 2018 21:42

[add]translations

4a29508

[add]making the login page sexier and minor text fixes

ba6a3cf

[remove]removed test code

cfbf531

[edit]indents to spaces...

3e8f103

[add]lock iv in config for non paying users

d4d8dd3

mfaalk and others added 14 commits March 27, 2018 17:06

[fix]change from sha1 to password_hash encryption

9c29415

[fix]indeeeeeeeents <3

927eea7

[add]forgot password form, design update and db structure change.

836252c

[fix]comma

76fa9fe

[fix]indents to spaces

62b22fa

[add]added possibiliy to create admin accounts

87376fa

[fix]minor text fixes

1501bd3

[add]admin features etc...

576bb5b

[add]account creation

279fa20

ooops

5c8fb4f

minor text fixes

917c554

[add]logging all queries for emergency

6b2aff4

[fix]permission

43c3a34

[fix]test

d9f27fa

mfaalk closed this Apr 4, 2018

Conversation

mfaalk commented Mar 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hammydown4325 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Glennmen commented Mar 27, 2018

Uh oh!

mfaalk commented Mar 27, 2018

Uh oh!

Glennmen commented Mar 27, 2018

Uh oh!

mfaalk commented Apr 4, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mfaalk commented Mar 26, 2018 •

edited

Loading