Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rollbar configuration #635

Merged
merged 6 commits into from
Mar 14, 2024
Merged

Added rollbar configuration #635

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1d27ed5
Added rollbar configuration.
balagan73 Mar 4, 2024
2babcb2
Updated README.md.
balagan73 Mar 5, 2024
97650a9
Readme changes.
balagan73 Mar 5, 2024
b5ddde6
Added quotes in README.md.
balagan73 Mar 5, 2024
0b13d4c
Fixed rollbar config settings.
balagan73 Mar 8, 2024
ec68888
Updated readme and settings.pantheon.php file.
balagan73 Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,10 @@ if you are using other IDE or want to know more about this feature.

## Deploy to Pantheon

### Rollbar configuration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move it under Deploy to Pantheon and remove Prepare for Deployment


Rollbar will be automatically enabled on test and live environments. The access tokens need to be added under '/admin/config/services/rollbar' and the rollbar configuration yml file should be committed.
Copy link
Member

@amitaibu amitaibu Mar 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, instead of /admin/config/services/rollbar - can't we have the setting placeholder on settings.pantheon.php?


### Pantheon Setup

Follow the steps listed in `.ddev/providers/pantheon.yaml`.
Expand Down
11 changes: 7 additions & 4 deletions web/sites/default/settings.pantheon.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,14 @@
if (file_exists($local_settings)) {
include $local_settings;
}

$pantheon_env = getenv('PANTHEON_ENVIRONMENT');
$pantheon_site_name = getenv('PANTHEON_SITE_NAME');
$base_private_dir = '../config/elasticsearch';
$settings['site_id'] = 'drupal_starter';
if (file_exists($base_private_dir . '/' . $settings['site_id'] . '.es.secrets.json')) {
$es_credentials = json_decode(file_get_contents($base_private_dir . '/' . $settings['site_id'] . '.es.secrets.json'), TRUE);
if (is_array($es_credentials)) {
$fallback = 'dev';
$pantheon_env = getenv('PANTHEON_ENVIRONMENT');
$env = str_replace('-', '_', !empty($pantheon_env) ? $pantheon_env : $fallback);

if (!isset($es_credentials[$env])) {
Expand All @@ -70,9 +70,12 @@
}
}
}

$pantheon_env = getenv('PANTHEON_ENVIRONMENT');
if (!empty($pantheon_env)) {
// Rollbar settings for LIVE and TEST.
if ($pantheon_env == 'live' || $pantheon_env == 'test') {
$config['rollbar.settings']['environment'] = $pantheon_site_name . '.' . $pantheon_env;
$config['rollbar.settings']['enabled'] = TRUE;
}
switch ($pantheon_env) {
case 'test':
$config['environment_indicator.indicator']['bg_color'] = '#ffcc6b';
Expand Down