Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix similarity detection #1535

Merged
merged 1 commit into from
Aug 22, 2024
Merged

fix similarity detection #1535

merged 1 commit into from
Aug 22, 2024

Conversation

fowles
Copy link
Contributor

@fowles fowles commented Aug 22, 2024

track all removed tokens and not the most recent batch only

track all removed tokens and not the most recent batch only
@martinvonz
Copy link
Contributor

@Byron: This fix seems pretty important to jj users. When do you expect it will be released? I didn't see an obvious pattern to Gitoxide releases (seems roughly around the middle of each month but not quite). Just trying to decide how to plan our releases for it.

Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great!

@Byron: This fix seems pretty important to jj users. When do you expect it will be released? I didn't see an obvious pattern to Gitoxide releases (seems roughly around the middle of each month but not quite). Just trying to decide how to plan our releases for it.

I will try to just release gix-diff as patch release, which will probably allow you to pick that up and perform a release of jj as you see fit.
If that's not possible, I will try to create a new gix release.

@Byron Byron merged commit 6990afd into GitoxideLabs:main Aug 22, 2024
19 checks passed
@fowles fowles deleted the diff branch August 22, 2024 18:09
@martinvonz
Copy link
Contributor

I will try to just release gix-diff as patch release, which will probably allow you to pick that up and perform a release of jj as you see fit.
If that's not possible, I will try to create a new gix release.

Thanks!

@Byron
Copy link
Member

Byron commented Aug 22, 2024

gix v0.66 is now available: https://github.com/Byron/gitoxide/releases/tag/gix-v0.66.0 - v0.65 was botched so I had to re-release. Quite a mess, once again, due to a breaking change not being signalled as one (or somehow the safety-bumping didn't work).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants