various improvements #1520
Merged
various improvements #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byron
force-pushed
the
improvements
branch
2 times, most recently
from
0f4f75b to
4eed4c2
Compare
|
@Jake-Shadle Would you be interested in adding |
|
Why would it not be straightforward? |
|
Your optimism is encouraging though. |
With it it's easier to obtain reasonable object cache sizes as optimized for tree-diffs.
Byron
force-pushed
the
improvements
branch
2 times, most recently
from
d74833b to
a6da915
Compare
This also renames `TargetRef::Peeled` to `TargetRef::Object` to make clear that it's not necessarily the peeled object that is contained. Previously these terms were confusing due to the incorrect usage of the word `peeled`.
The missing link that makes it possible to follow to the first object and then peel the object according to any preferred algorithm.
Make it easy to follow a ref and peel it to a given object type. Additional `peel_to_<kind>()` shortcuts are also provided, with the same name as in `git2`.
It's an equivalent to `git2::Reference::resolve()`.`
This works by providing `Change::detach()` and `ChangeDetached::attach()`.
…diff-stats. This function is inspired by `git2` which also makes it very simple to obtain.
It allows to keep a free-list of buffers around after clearing, to help prevent re-allocating and growing bufers over and over.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various API changes to make diffing between trees and stats-retrieval less cumbersome.
Additionally, add more methods to make API more similar to
git2where it's clearly for convenience.Related to gitbutlerapp/gitbutler#4670 .
Tasks