fix test-lib archive creation #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with arguments. (#1440) Previously there was a race condition that would cause archives to be created either with or without arguments, depending on which test was run first. After its creation, they wouldn't be looked at again as on disk they would already be available in their usable form.
EliahKagan
reviewed
Jul 4, 2024
| let link_entry_oid = hex_to_id("2e65efe2a145dda7ee51d1741299f848e5bf752e"); | ||
| #[cfg(not(windows))] | ||
| let link_entry_mode = EntryKind::Link; |
There was a problem hiding this comment.
As detailed in #1442 and mentioned in #1440 (comment), this changes the expected hash values to what I believe they should be on all platforms including Windows, but currently the repository that is created when the fixture script is actually run on Windows produces the situation described by the old values.
This comment is for reference in connection with #1442. I do not advocate the old code here be brought back.
(For some reason GitHub is not showing the whole diff here, even though I selected it when making this comment. Oh well.)
There was a problem hiding this comment.
I see, thank you! I yet have to catch up on the new issues though, to see if there is anything that can be done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there was a race condition that would cause archives to be created either with or without arguments, depending on which test was run first.
After its creation, they wouldn't be looked at again as on disk they would already be available in their usable form.
Fixes #1440.