Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reproduce failure when parsing malformed commit (#1438) #1439

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Conversation

Byron
Copy link
Member

@Byron Byron commented Jul 3, 2024

Note that Git can parse it.

It's notable that it parses the name as Gregor Hartmann and the email as gh <Gregor Hartmann<[email protected], while the author/commiter lines are Gregor Hartmann<gh <Gregor Hartmann<[email protected]>>

Tasks

  • reproduce issue
  • make commit parser more more flexible

Note that Git can parse it.

It's notable that it parses the name as `Gregor Hartmann`
and the email as `gh <Gregor Hartmann<[email protected]`,
while the author/commiter lines are
`Gregor Hartmann<gh <Gregor Hartmann<[email protected]>>`
@Byron Byron merged commit 9717a25 into main Jul 3, 2024
19 checks passed
@Byron Byron deleted the fix-1438 branch July 3, 2024 18:44
@Byron Byron mentioned this pull request Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parsing failure of invalid author/committer line - missing space before email
1 participant