-
Notifications
You must be signed in to change notification settings - Fork 84
Fix Front script injection #1054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…e script now appends to the `<body>` element as recommended by Front, and a duplicate `appendChild` call has been removed.
|
commit: |
|
👇 Not sure what I can do about that failing Check integrations check (looks like it wants 1Password access?) |
|
Hi @dugjason Thanks for investigating this with us! And thanks for starting this PR. I’ve tested this out, but it’s still not working. After debugging a little more, it looks like it’s coming from the It’s currently injecting It looks like updating it to CleanShot.2025-11-18.at.18.18.17.mp4 |
|
Good find - thanks @addisonschultz That being said - the way the chat widget is currently implemented (loading in the |
|
@dugjason yes - thanks again for making this PR to fix the script injection. The 1password check is an ongoing issue we have from external PRs, I’ve verified the changes are valid and it’s good to go since the other checks are passing. I will leave this PR open for now, in case we have a resolution from the product team soon? If we need to make any additional changes here? |
|
Thanks Addison - sounds like a plan. We'll get back to you as we have news |
Fixes script injection issue.
The script now appends to the
<body>element as recommended by Front, and a duplicateappendChildcall has been removed.Refer to Front docs https://help.front.com/en/articles/2049#install_front_chat_on_your_website