Skip to content

Mini Optimization: Avoid stating the file twice #512

Mini Optimization: Avoid stating the file twice

Mini Optimization: Avoid stating the file twice #512

GitHub Actions / Unit Tests macOS-latest stable failed Sep 6, 2024 in 0s

134 passed, 32 failed and 2 skipped

Tests failed

❌ test-results.json

168 tests were completed in 138s with 134 passed, 32 failed and 2 skipped.

Test suite Passed Failed Skipped Time
test/async_repo_test.dart 1✅ 421ms
test/blob_ctime_builder_test.dart 1❌ 451ms
test/branch_test.dart 1✅ 407ms
test/commands/commit_test.dart 1✅ 1❌ 30s
test/commands/merge_delete_test.dart 1❌ 4s
test/commands/merge_test.dart 3❌ 15s
test/commands/reset_test.dart 1❌ 227ms
test/commands/single_commands_test.dart 16✅ 11❌ 63s
test/commit_test.dart 2❌ 764ms
test/config_test.dart 3✅ 140ms
test/diff_commit_test.dart 1✅ 499ms
test/file_mtime_builder_test.dart 1❌ 484ms
test/git_hash_test.dart 2✅ 75ms
test/git_test.dart 1✅ 162ms
test/git_url_parse_test.dart 29✅ 119ms
test/idx_file_test.dart 4✅ 159ms
test/index_test.dart 8✅ 266ms
test/is_ssh_url_test.dart 24✅ 87ms
test/merge_base_test.dart 23✅ 318ms
test/packfile_test.dart 4❌ 313ms
test/plumbing/commit_iterator_bfs_filtered_test.dart 5❌ 169ms
test/plumbing/commit_iterator_test.dart 2❌ 143ms
test/plumbing/ignore_test.dart 1✅ 71ms
test/plumbing/objects/blob_test.dart 1✅ 148ms
test/plumbing/objects/commit_test.dart 5✅ 161ms
test/plumbing/objects/kvlm_test.dart 3✅ 88ms
test/plumbing/objects/tree_test.dart 1✅ 148ms
test/plumbing/pack_file_delta_test.dart 2⚪ 1ms
test/utils/date_time_test.dart 9✅ 120ms

✅ test/async_repo_test.dart

✅ Basic

❌ test/blob_ctime_builder_test.dart

❌ Basic
	FormatException: Filter error, bad data

✅ test/branch_test.dart

✅ Branch with a /

❌ test/commands/commit_test.dart

❌ Commit all Initial Repo Test - Single File
	TimeoutException after 0:00:30.000000: Test timed out after 30 seconds. See https://pub.dev/packages/test#timeouts
✅ Sort directories

❌ test/commands/merge_delete_test.dart

❌ merge del2
	ShellException(/Users/runner/work/dart-git/dart-git/bin/main.dart merge del2, exitCode 1, workingDirectory: /var/folders/4d/0gnh84wj53j7wyk695q0tc_80000gn/T/_git_zKy3iN/merge-delete_dart)

❌ test/commands/merge_test.dart

❌ merge fast-forward
	ShellException(/Users/runner/work/dart-git/dart-git/bin/main.dart merge fast-forward, exitCode 1, workingDirectory: /var/folders/4d/0gnh84wj53j7wyk695q0tc_80000gn/T/_git_BYUQ6j/merge_dart)
❌ merge up-to-date
	ShellException(/Users/runner/work/dart-git/dart-git/bin/main.dart merge up-to-date, exitCode 1, workingDirectory: /var/folders/4d/0gnh84wj53j7wyk695q0tc_80000gn/T/_git_BYUQ6j/merge_dart)
❌ merge merge-conflict -X ours
	ShellException(/Users/runner/work/dart-git/dart-git/bin/main.dart merge merge-conflict -X ours, exitCode 1, workingDirectory: /var/folders/4d/0gnh84wj53j7wyk695q0tc_80000gn/T/_git_BYUQ6j/merge_dart)

❌ test/commands/reset_test.dart

❌ reset --hard HEAD^
	Expected: <0>
	  Actual: <1>
	Dart command `reset --hard HEAD^` failed in /var/folders/4d/0gnh84wj53j7wyk695q0tc_80000gn/T/_git_VrOSKj/merge_dart
	

❌ test/commands/single_commands_test.dart

✅ branch
✅ branch test
✅ branch -a
❌ write-tree
	Expected: <0>
	  Actual: <1>
	Dart command `write-tree` failed in /var/folders/4d/0gnh84wj53j7wyk695q0tc_80000gn/T/_git_e50j6I/dart_git_dart
	
✅ rm LICENSE
❌ diff-tree 938c320fd826711ab4e3f5db5cf2f4557ff75522
	Expected: <0>
	  Actual: <1>
	Dart command `diff-tree 938c320fd826711ab4e3f5db5cf2f4557ff75522` failed in /var/folders/4d/0gnh84wj53j7wyk695q0tc_80000gn/T/_git_e50j6I/dart_git_dart
	
❌ diff-tree 6216f82ecd10cac78c2b90ddcc4d0d9dc6f3d711
	Expected: <0>
	  Actual: <1>
	Dart command `diff-tree 6216f82ecd10cac78c2b90ddcc4d0d9dc6f3d711` failed in /var/folders/4d/0gnh84wj53j7wyk695q0tc_80000gn/T/_git_e50j6I/dart_git_dart
	
✅ rm does-not-exist
✅ branch -d not-existing
✅ branch master
✅ rm /outside-rep
❌ checkout 1 file
	Expected: <0>
	  Actual: <1>
	Dart command `checkout LICENSE` failed in /var/folders/4d/0gnh84wj53j7wyk695q0tc_80000gn/T/_git_e50j6I/dart_git_dart
	
✅ git rm deleted file
✅ git delete branch
✅ git upstream branch
✅ git remote
❌ git checkout remote branch
	Expected: <0>
	  Actual: <1>
	Dart command `checkout -b master origin/master` failed in /var/folders/4d/0gnh84wj53j7wyk695q0tc_80000gn/T/_git_e50j6I/dart_git_dart
	
❌ git checkout branch
	Expected: <0>
	  Actual: <1>
	Dart command `checkout branch-for-ítesting` failed in /var/folders/4d/0gnh84wj53j7wyk695q0tc_80000gn/T/_git_e50j6I/dart_git_dart
	
❌ reset --hard
	Expected: <0>
	  Actual: <1>
	Dart command `reset --hard HEAD^` failed in /var/folders/4d/0gnh84wj53j7wyk695q0tc_80000gn/T/_git_e50j6I/dart_git_dart
	
❌ reset --hard
	Expected: <0>
	  Actual: <1>
	Dart command `reset --hard ef2118f9ed53fdc4c7c6104cbff7489612d76c0d` failed in /var/folders/4d/0gnh84wj53j7wyk695q0tc_80000gn/T/_git_e50j6I/dart_git_dart
	
❌ checkout 1 file
	Expected: <0>
	  Actual: <1>
	Dart command `checkout LICENSE` failed in /var/folders/4d/0gnh84wj53j7wyk695q0tc_80000gn/T/_git_e50j6I/dart_git_dart
	
✅ git rm deleted file
✅ git delete branch
✅ git upstream branch
✅ git remote
❌ git checkout remote branch
	Expected: <0>
	  Actual: <1>
	Dart command `checkout -b master origin/master` failed in /var/folders/4d/0gnh84wj53j7wyk695q0tc_80000gn/T/_git_e50j6I/dart_git_dart
	
❌ git checkout branch
	Expected: <0>
	  Actual: <1>
	Dart command `checkout branch-for-ítesting` failed in /var/folders/4d/0gnh84wj53j7wyk695q0tc_80000gn/T/_git_e50j6I/dart_git_dart
	

❌ test/commit_test.dart

❌ fixture mtime
	FormatException: Filter error, bad data
❌ fixture merge
	FormatException: Filter error, bad data

✅ test/config_test.dart

✅ Config Branches Test
✅ Config Serialization
✅ ConfigFile Serialization

✅ test/diff_commit_test.dart

✅ Duplicate Tree Object

❌ test/file_mtime_builder_test.dart

❌ Basic
	FormatException: Filter error, bad data

✅ test/git_hash_test.dart

✅ Equality
✅ Zero Equality

✅ test/git_test.dart

✅ Test can Push

✅ test/git_url_parse_test.dart

all
  ✅ ssh://[email protected]:42/path/to/repo.git/
  ✅ git+ssh://[email protected]/path/name.git
  ✅ ssh://[email protected]/path/to/repo.git/
  ✅ ssh://host.xz:5497/path/to/repo.git/
  ✅ ssh://host.xz/path/to/repo.git/
  ✅ [email protected]:42foo/bar.git
  ✅ ssh://[email protected]/~user/path/to/repo.git/
  ✅ ssh://host.xz/~user/path/to/repo.git/
  ✅ ssh://[email protected]/~/path/to/repo.git
  ✅ ssh://host.xz/~/path/to/repo.git
  ✅ [email protected]:/path/to/repo.git/
  ✅ [email protected]:~user/path/to/repo.git/
  ✅ [email protected]:path/to/repo.git
  ✅ rsync://host.xz/path/to/repo.git/
  ✅ git://host.xz/path/to/repo.git/
  ✅ git://host.xz/~user/path/to/repo.git/
  ✅ http://host.xz/path/to/repo.git/
  ✅ https://host.xz/path/to/repo.git/
  ✅ https://token:[email protected]/path/to/repo.git/
  ✅ https://x-token-auth:[email protected]/path/to/repo.git/
  ✅ https://[email protected]/user/repo
  ✅ https://[email protected]/name.git
  ✅ https://token:[email protected]/owner/name.git
  ✅ https://x-token-auth:[email protected]/owner/name.git
  ✅ /path/to/repo.git/
  ✅ path/to/repo.git/
  ✅ ~/path/to/repo.git
  ✅ file:///path/to/repo.git/
  ✅ [email protected]:path/name.git

✅ test/idx_file_test.dart

✅ IdxFile Parser
✅ IdxFile Parser 64bit
✅ Idx file serialize
✅ Idx file 64 bit serialize

✅ test/index_test.dart

✅ Decode
✅ Decode Entries
✅ Decode Cache Tree Extension
✅ Serialize
✅ Decode Merge Conflict
✅ End of index entry
✅ Decode go-git-fixtures indexes
✅ decode v4

✅ test/is_ssh_url_test.dart

all
  ✅ ssh://[email protected]:port/path/to/repo.git/
  ✅ ssh://[email protected]/path/to/repo.git/
  ✅ ssh://host.xz:port/path/to/repo.git/
  ✅ ssh://host.xz/path/to/repo.git/
  ✅ ssh://[email protected]/~user/path/to/repo.git/
  ✅ ssh://host.xz/~user/path/to/repo.git/
  ✅ ssh://[email protected]/~/path/to/repo.git
  ✅ ssh://host.xz/~/path/to/repo.git
  ✅ [email protected]:/path/to/repo.git/
  ✅ [email protected]:~user/path/to/repo.git/
  ✅ [email protected]:path/to/repo.git
  ✅ host.xz:/path/to/repo.git/
  ✅ host.xz:path/to/repo.git
  ✅ host.xz:~user/path/to/repo.git/
  ✅ rsync://host.xz/path/to/repo.git/
  ✅ git://host.xz/path/to/repo.git/
  ✅ git://host.xz/~user/path/to/repo.git/
  ✅ http://host.xz/path/to/repo.git/
  ✅ https://host.xz/path/to/repo.git/
  ✅ /path/to/repo.git/
  ✅ path/to/repo.git/
  ✅ ~/path/to/repo.git
  ✅ file:///path/to/repo.git/
  ✅ file://~/path/to/repo.git/

✅ test/merge_base_test.dart

MergeBase
  ✅ NoAncestorsWhenNoCommonHistory
  ✅ CommonAncestorInMergedOrphans
  ✅ MergeBaseWithSelf
  ✅ MergeBaseWithAncestor
  ✅ DoubleCommonAncestorInCrossMerge
  ✅ DoubleCommonInSubFeatureBranches
Independents
  ✅ OnlyOne
  ✅ OnlyRepeated
  ✅ RepeatedAncestors
  ✅ BeyondShortcut
  ✅ BeyondShortcutBis
  ✅ PairOfAncestors
  ✅ AcrossCrossMerges
  ✅ ChangingOrderRepetition
  ✅ ChangingOrder
  ✅ ParentChild
Ancestor
  ✅ OnlyOne
  ✅ OnlyOneRev
  ✅ BeyondMerges
  ✅ BeyondMergesRev
  ✅ AncestorSame
  ✅ AncestorUnrelated
  ✅ AncestorUnrelatedRev

❌ test/packfile_test.dart

❌ Packfile
	FormatException: Filter error, bad data
❌ Packfile with deltas
	FormatException: Filter error, bad data
❌ Packfile with deltas 2
	FormatException: Filter error, bad data
❌ Packfile with Ref Delta
	FormatException: Filter error, bad data

❌ test/plumbing/commit_iterator_bfs_filtered_test.dart

❌ Basic
	FormatException: Filter error, bad data
❌ Filter All But One
	FormatException: Filter error, bad data
❌ Filter All
	FormatException: Filter error, bad data
❌ isLimit
	FormatException: Filter error, bad data
❌ isValid and isLimit
	FormatException: Filter error, bad data

❌ test/plumbing/commit_iterator_test.dart

❌ BFS
	FormatException: Filter error, bad data
❌ PreOrder
	FormatException: Filter error, bad data

✅ test/plumbing/ignore_test.dart

✅ TestSimpleMatch_inclusion

✅ test/plumbing/objects/blob_test.dart

✅ Reads the blob file correctly

✅ test/plumbing/objects/commit_test.dart

✅ Git Commit
✅ Commit with GPG
✅ Author Parse
✅ Author Serialize
✅ Author Serialize negative

✅ test/plumbing/objects/kvlm_test.dart

✅ Parses KVLM Properly
✅ Parse test commit
✅ Parse empty

✅ test/plumbing/objects/tree_test.dart

✅ Reads the tree file correctly

✅ test/plumbing/pack_file_delta_test.dart

⚪ AddDelta
⚪ IncompleteDelta

✅ test/utils/date_time_test.dart

✅ timeZoneOffset
✅ millisecondsSinceEpoch
✅ microsecondsSinceEpoch
✅ secondsSinceEpoch
✅ toUTC
✅ Parse
Constructors
  ✅ Default
  ✅ Default, only year argument
  ✅ from DateTime