Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update section in README for Python support #1050

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

mathieubellon
Copy link
Collaborator

Update Readme to indicate our Python version support

@mathieubellon mathieubellon requested a review from a team as a code owner January 23, 2025 07:45
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.76%. Comparing base (c405695) to head (07ec91f).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1050   +/-   ##
=======================================
  Coverage   91.76%   91.76%           
=======================================
  Files         143      143           
  Lines        6048     6048           
=======================================
  Hits         5550     5550           
  Misses        498      498           
Flag Coverage Δ
unittests 91.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@agateau-gg agateau-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about one of the changes, commented on it.

CI is unhappy because the TOC is not in sync (the Requirements section is gone). Installing the pre-commit hooks should fix that automatically.

Don't forget to do the synchronization work mentioned in the comment below "# Installation".

README.md Show resolved Hide resolved
docs: clarify requirements for Docker and Pypi commands in README

docs: Doctoc update
@sevbch sevbch force-pushed the mbellon/python-support branch from 4cadd72 to 07ec91f Compare January 28, 2025 16:41
@sevbch sevbch requested a review from agateau-gg January 28, 2025 16:41
@sevbch
Copy link
Contributor

sevbch commented Jan 28, 2025

@agateau-gg I squashed the commits and fixed the linting issue. Is it all good to go for you?

@agateau-gg
Copy link
Collaborator

Looks good!

@agateau-gg agateau-gg merged commit ddd988f into main Jan 28, 2025
32 checks passed
@agateau-gg agateau-gg deleted the mbellon/python-support branch January 28, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants