Enchance tooltip label #95
Open
+42
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KrystofVavra
left a comment
KrystofVavra
left a comment
There was a problem hiding this comment.
I’m not really sure why you decided to do this. What was the issue or use case? I feel like everything needed for the demo was already present...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reusable tooltip label handling in @gisatcz/ptr-fe-core so both native and custom tooltips share the same formatting logic, and wired the new options through MapSet’s tooltip.
The labelTemplate and excludeKeys are now supported and [key] substitution is centralized.
PR Details:
Added TooltipAttributeOptions and label substitution + exclusion handling in getTooltipAttributes.ts.
Passed labelTemplate/excludeKeys from geojsonOptions.tooltipSettings into getTooltipAttributes in handleMapHover.ts and getMapTooltip.ts.
Removed the manual label substitution in getMapTooltip.ts because it now happens in the shared helper.
Important: The demo that reflects how to use tooltip is presented in fe-core: https://github.com/Gisat/fe-core/pull/314