-
Notifications
You must be signed in to change notification settings - Fork 0
Map layers refactoring #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vlach1989
wants to merge
4
commits into
dev
Choose a base branch
from
refactoring/map-layers
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+565
−126
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| import React, { useEffect, useMemo } from 'react'; | ||
| import geolib from '@gisatcz/deckgl-geolib'; | ||
| import { Layer } from '@deck.gl/core'; | ||
| import { LayerSourceProps } from './LayerManager'; | ||
| import { parseDatasourceConfiguration } from '../../../shared/models/parsers.datasources'; | ||
|
|
||
| const CogBitmapLayer = geolib.CogBitmapLayer; | ||
|
|
||
| /** | ||
| * A React component that creates and manages a COG (Cloud Optimized GeoTIFF) layer. | ||
| * This component uses the `CogBitmapLayer` from `@gisatcz/deckgl-geolib` to render raster data. | ||
| * | ||
| * @param {LayerSourceProps} props - The props for the COGLayerSource component. | ||
| * @param {RenderingLayer} props.layer - The layer configuration object. | ||
| * @param {(id: string, instance: Layer | null) => void} props.onLayerUpdate - Callback to handle updates to the layer instance. | ||
| * @returns {null} This component does not render any DOM elements. | ||
| */ | ||
| export const COGLayerSource = React.memo(({ layer, onLayerUpdate }: LayerSourceProps) => { | ||
| // Destructure properties from the layer configuration | ||
| const { isActive, key, opacity, datasource } = layer; | ||
| const { url, configuration } = datasource; | ||
|
|
||
| // Ensure the URL is provided in the datasource | ||
| if (!url) { | ||
| throw new Error(`COGLayerSource: Missing url in datasource: ${key}`); | ||
| } | ||
|
|
||
| // Parse the datasource configuration | ||
| const config = parseDatasourceConfiguration(configuration); | ||
| if (!config) { | ||
| // Log a warning if the configuration is missing | ||
| console.warn(`COGLayerSource: Missing configuration in datasource: ${key}`); | ||
| } | ||
|
|
||
| // Extract COG bitmap options from the parsed configuration | ||
| const cogBitmapOptions = config?.cogBitmapOptions; | ||
| if (!cogBitmapOptions) { | ||
| // Log a warning if the COG bitmap options are missing | ||
| console.warn(`COGLayerSource: Missing cogBitmapOptions in datasource configuration: ${key}`); | ||
| } | ||
|
|
||
| /** | ||
| * Memoize the creation of the CogBitmapLayer instance to avoid unnecessary re-renders. | ||
| * The layer instance is recreated only when its dependencies change. | ||
| */ | ||
| const layerInstance: Layer = useMemo(() => { | ||
| if (!cogBitmapOptions) { | ||
| return null; | ||
| } | ||
| return new CogBitmapLayer({ | ||
| id: key, | ||
| rasterData: url, | ||
| isTiled: true, | ||
| opacity: opacity ?? 1, | ||
| visible: isActive, | ||
| cogBitmapOptions, | ||
| }); | ||
| /* TODO: Since cogBitmapOptions is derived from configuration, which originally is a string | ||
| (from ptr-be-core model HasConfiguration) and later parsed to an object, | ||
| we need to stringify it here to avoid infinite render loops due to object reference changes. */ | ||
| }, [url, isActive, key, opacity, JSON.stringify(cogBitmapOptions)]); | ||
|
|
||
| /** | ||
| * Effect hook to handle layer updates. | ||
| * The `onLayerUpdate` callback is called with the layer instance when the component mounts | ||
| * and with `null` when the component unmounts. | ||
| */ | ||
| useEffect(() => { | ||
| onLayerUpdate(key, layerInstance); | ||
| return () => onLayerUpdate(key, null); // Cleanup on unmount | ||
| }, [layerInstance, key, onLayerUpdate]); | ||
|
|
||
| // This component does not render any DOM elements | ||
| return null; | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
JSON.stringify(cogBitmapOptions)in the dependency array causes the useMemo to recompute on every render when cogBitmapOptions is an object, defeating its purpose. Consider using a more stable approach such as storing the stringified value in a separate useMemo, or redesigning the data flow to avoid object reference changes.