fix: resolve issues #195, #181, #009, #161 — license, whitepaper, vesting events, bulk payment events#531
Merged
Wilfred007 merged 1 commit intoGildado:mainfrom Mar 27, 2026
Conversation
…icense, whitepaper, vesting events, bulk payment event structs closes Gildado#492 closes Gildado#478 closes Gildado#194 closes Gildado#458 - Gildado#195 (issue Gildado#492): Replace Apache-2.0 LICENSE with MIT for 2026; update Cargo.toml workspace license field to match README badge - Gildado#181 (issue Gildado#478): Add docs/whitepaper.md — technical overview of the PayD cross-border payroll protocol covering Stellar/Soroban architecture, BulkPayment and VestingEscrow contract design, asset model, security model, and off-chain components - Gildado#9 (issue Gildado#194): Add Soroban contractevent types to vesting_escrow — VestingInitializedEvent, TokensClaimedEvent, ClawbackExecutedEvent — and emit them from initialize, claim, and clawback respectively so on-chain indexers can track full grant lifecycle - Gildado#161 (issue Gildado#458): Define missing BatchExecutedEvent and BatchPartialEvent structs (previously used but undeclared, which would fail compilation); add per-payment PaymentSentEvent emissions inside execute_batch so individual payout completions are observable in the event log Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
|
@boys-cyberhub Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #492 · Closes #478 · Closes #194 · Closes #458
This PR addresses four open issues in a single atomic change:
#195 — Improve License Visibility (issue #492)
LICENSEfile with a proper MIT license dated 2026Cargo.tomlworkspacelicensefield from"Apache-2.0"to"MIT"to match the existing README badge#181 — Technical Whitepaper for PayD Protocol (issue #478)
docs/whitepaper.md— a comprehensive Markdown whitepaper covering:#9 — Soroban VestingEscrow Events (issue #194)
#[contractevent]types tocontracts/vesting_escrow/src/lib.rs:VestingInitializedEvent— emitted on successfulinitializeTokensClaimedEvent— emitted on successfulclaim(skipped when nothing claimable)ClawbackExecutedEvent— emitted on successfulclawback#161 — Improve Event Logging in Bulk Payment Contract (issue #458)
BatchExecutedEventandBatchPartialEventstructs (they were referenced in the code but never declared, which would cause a compile error)PaymentSentEventemissions insideexecute_batchso individual payout completions within a batch are now observable in the event log (previously only a batch-level summary event was emitted)Test plan
cargo build --target wasm32-unknown-unknownpasses for bothbulk_paymentandvesting_escrowcargo test -p bulk_paymentandcargo test -p vesting_escrow) pass without modificationdocs/whitepaper.mdrenders correctly in GitHub markdown previewBatchExecutedEvent,BatchPartialEvent,VestingInitializedEvent,TokensClaimedEvent,ClawbackExecutedEvent) are visible in compiled contract ABI🤖 Generated with Claude Code