fix: disable RMT channel before deletion to prevent channel leak#286
Draft
Mimsseey wants to merge 1 commit intoGhostESP-Revival:Development-dekifrom
Draft
fix: disable RMT channel before deletion to prevent channel leak#286Mimsseey wants to merge 1 commit intoGhostESP-Revival:Development-dekifrom
Mimsseey wants to merge 1 commit intoGhostESP-Revival:Development-dekifrom
Conversation
The RMT driver requires channels to be in init (disabled) state before deletion. led_strip_rmt_del() was calling rmt_del_channel() while the channel was still enabled, causing "channel not in init state" errors and leaking the RMT channel. Also moved channel_enabled from static global to per-instance field so reinit works correctly after deinit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What's new (Author - fill this out)
The RMT driver requires channels to be in init (disabled) state before deletion. led_strip_rmt_del() was calling rmt_del_channel() while the channel was still enabled, causing "channel not in init state" errors and leaking the RMT channel. Also moved channel_enabled from static global to per-instance field so reinit works correctly after deinit
Changed
Removed
Verification (Author - fill this out)
#ifdef CONFIG_...or similar: [ ] Yes / [ ] N/ALinked Issues
Checklist (Reviewer - don't fill this out)