Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure lists/maps in data components are immutable, add lombok's @Builder's for ease of use #882

Conversation

onebeastchris
Copy link
Member

No description provided.

# Conflicts:
#	protocol/src/main/java/org/geysermc/mcprotocollib/protocol/codec/MinecraftTypes.java
Copy link
Contributor

@AlexProgrammerDE AlexProgrammerDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@onebeastchris onebeastchris changed the title Ensure lists/maps in data components are immutable, add lombok's @With and @Builder's for ease of use Ensure lists/maps in data components are immutable, add lombok's @Builder's for ease of use Feb 18, 2025
@onebeastchris onebeastchris force-pushed the fix-mutable-collections-in-components branch from 252a415 to b1250a5 Compare February 18, 2025 17:55
@onebeastchris onebeastchris merged commit 5743ca3 into GeyserMC:master Feb 18, 2025
1 check passed
@onebeastchris onebeastchris deleted the fix-mutable-collections-in-components branch February 18, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants