Skip to content
This repository was archived by the owner on Jul 21, 2024. It is now read-only.

wiki setup changes #86

Merged
merged 26 commits into from
Oct 4, 2022
Merged

wiki setup changes #86

merged 26 commits into from
Oct 4, 2022

Conversation

onebeastchris
Copy link
Member

Hey! As Jens asked for help with a small rewrite, i gave it a shot - here are my proposed changes.

Overview:

  • split apart the standalone, and plugin instructions to reduce confusion
  • added some config steps with the plugin setup
  • added the secureprofiles notice in the Prerequesites section
  • made the "overview" a bit clearer - i like lists
  • added more detail to the Bungee/Velocity setup
  • didn't change standalone instructions.
  • added a quick tip to the pterodactly egg notice in the faq, as advised on discord https://discord.com/channels/613163671870242838/613168464634576897/1022433712983523368

This is my first time editing the wiki - the links may not work correctly.

@onebeastchris onebeastchris requested review from a team as code owners September 23, 2022 18:13
@onebeastchris
Copy link
Member Author

I'm not sure what else to add to the "enforce-secure-profiles" - should there be a warning that chat reporting wouldn't work? Or are the current changes enough

@Camotoy
Copy link
Member

Camotoy commented Sep 27, 2022

I would add that other Java players can join that don't abide by chat signing.

@onebeastchris
Copy link
Member Author

Something like this? Unfortunately, I'm not entirely sure on the technical process, so i can't give exact info - but considering this is a general setup page, maybe a link to some technical site would be better. But potentially out-of-scope, considering this could make them not want to use Geyser

Updated version number to the correct version. Unless any other changes are requested, i don't plan on adding further on this PR
@onebeastchris
Copy link
Member Author

Updated the version from 1.12.2 to 1.13.2 in the Prerequisites section. If you'd like me to change anything, lmk!

@onebeastchris
Copy link
Member Author

whoopsie, imma try and fix permalink -

@onebeastchris
Copy link
Member Author

should hopefully work now, i forgot to change the page permalink

Copy link
Member

@jackson-57 jackson-57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through and left suggestions for grammar and punctuation. Most of it is quite minor. If you disagree with anything, feel free to reject the suggestion. I wasn't super thorough in my review, so I might have missed something.

@onebeastchris
Copy link
Member Author

now to fix the missing permalink in the toc.yml file - I'll try and fix that

@onebeastchris
Copy link
Member Author

onebeastchris commented Oct 4, 2022

okay, should be fixed now. I'd try it myself, but for some reason, getting the website to run has proven to be a bit.. difficult. Will try later, but I'd say there's a decent chance it'll work

edit: works!

Copy link
Member

@Jens-Co Jens-Co left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this pr, nice work!

@jackson-57 jackson-57 merged commit cb52ea3 into GeyserMC:master Oct 4, 2022
Copy link

@Bijoygamer Bijoygamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O

@Chew
Copy link
Member

Chew commented Jan 2, 2023

Please don't necro merged PRs from months ago, seriously man?

@GeyserMC GeyserMC locked as resolved and limited conversation to collaborators Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants