Block-related updates

- Fix block breaking animation - Fix block breaking particles - Don't initialize Geyser's chunk cache if using Spigot
GeyserMC · Jul 7, 2020 · f68632f · f68632f
1 parent 24f9651
commit f68632f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/connector/src/main/java/org/geysermc/connector/network/session/cache/ChunkCache.java b/connector/src/main/java/org/geysermc/connector/network/session/cache/ChunkCache.java
@@ -29,6 +29,7 @@
 import com.github.steveice10.mc.protocol.data.game.chunk.Column;
 import com.github.steveice10.mc.protocol.data.game.entity.metadata.Position;
 import lombok.Getter;
+import org.geysermc.connector.bootstrap.GeyserBootstrap;
 import org.geysermc.connector.network.session.GeyserSession;
 import org.geysermc.connector.network.translators.world.block.BlockTranslator;
 import org.geysermc.connector.network.translators.world.chunk.ChunkPosition;
@@ -38,15 +39,17 @@
 
 public class ChunkCache {
 
-    private boolean cache;
-    private final GeyserSession session;
+    private final boolean cache;
 
     @Getter
     private Map<ChunkPosition, Column> chunks = new HashMap<>();
 
     public ChunkCache(GeyserSession session) {
-        this.session = session;
-        this.cache = session.getConnector().getConfig().isCacheChunks();
+        if (session.getConnector().getWorldManager().getClass() == GeyserBootstrap.DEFAULT_CHUNK_MANAGER.getClass()) {
+            this.cache = session.getConnector().getConfig().isCacheChunks();
+        } else {
+            this.cache = false; // To prevent Spigot from initializing
+        }
     }
 
     public void addToCache(Column chunk) {

diff --git a/...main/java/org/geysermc/connector/network/translators/bedrock/BedrockActionTranslator.java b/...main/java/org/geysermc/connector/network/translators/bedrock/BedrockActionTranslator.java
@@ -112,7 +112,7 @@ public void translate(PlayerActionPacket packet, GeyserSession session) {
                 break;
             case CONTINUE_BREAK:
                 LevelEventPacket continueBreakPacket = new LevelEventPacket();
-                continueBreakPacket.setType(LevelEventType.BLOCK_UPDATE_BREAK); //TODO: There are now level event types for all breaks. Important?
+                continueBreakPacket.setType(LevelEventType.PARTICLE_CRACK_BLOCK);
                 continueBreakPacket.setData(BlockTranslator.getBedrockBlockId(session.getBreakingBlock()));
                 continueBreakPacket.setPosition(packet.getBlockPosition().toFloat());
                 session.sendUpstreamPacket(continueBreakPacket);

diff --git a/...geysermc/connector/network/translators/bedrock/BedrockInventoryTransactionTranslator.java b/...geysermc/connector/network/translators/bedrock/BedrockInventoryTransactionTranslator.java
@@ -152,7 +152,7 @@ public void translate(InventoryTransactionPacket packet, GeyserSession session)
                             session.setLastBlockPlacePosition(null);
 
                             LevelEventPacket blockBreakPacket = new LevelEventPacket();
-                            blockBreakPacket.setType(LevelEventType.BLOCK_STOP_BREAK); //TODO: Make sure this is the right new enum
+                            blockBreakPacket.setType(LevelEventType.PARTICLE_DESTROY_BLOCK);
                             blockBreakPacket.setPosition(packet.getBlockPosition().toFloat());
                             blockBreakPacket.setData(BlockTranslator.getBedrockBlockId(blockState));
                             session.sendUpstreamPacket(blockBreakPacket);