Fix a race condition with StreamVideo.removeClient()
#1553
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Goal
AND-869
Fix a race condition where
removeClientwould not be finished before calling a newbuild()causing an exception.Implementation
Add a synchronized block on the remove same as install.
Ensure that instance is cleared before calling cleanup.
Cleanup is then called on the previous instance regardless of weather a new instance will be created or not.
Testing
Reproduced with a unit test. Covered the scenario with a test.