Remove ThreadedCommentData operations from public api package
#103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
There was a problem hiding this comment.
Pull Request Overview
Moves internal ThreadedCommentData extension functions from the public API package to an internal package to improve API boundaries and encapsulation.
- Created new internal file containing the moved
ThreadedCommentDataoperations - Updated import statements in affected classes to reference the new internal package
- Removed unused imports from the public API file
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ThreadedCommentOperations.kt | New internal file containing moved ThreadedCommentData extension functions |
| ThreadedCommentData.kt | Removed internal extension functions and unused imports from public API |
| Various state and repository files | Updated imports to reference moved functions from internal package |
| Test files | Updated imports to reference moved functions from internal package |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...rc/main/kotlin/io/getstream/feeds/android/client/internal/state/CommentReplyListStateImpl.kt
Show resolved
Hide resolved
...rc/main/kotlin/io/getstream/feeds/android/client/internal/state/CommentReplyListStateImpl.kt
Show resolved
Hide resolved
SDK Size Comparison 📏
|
|
aleksandar-apostolov
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Part of AND-812.
We have internal functions in the api package, so I'm moving them to the
internalpackage. This PR does that for extensions onThreadedCommentDataImplementation
Just moving the functions.
Testing
Nothing should change.
Checklist