Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix timeout error #201

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

fix timeout error #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
adc9668
fix timeout error
sachaarbonel Feb 23, 2022
96aaa18
format
sachaarbonel Feb 24, 2022
70cb9e8
Merge branch 'master' into timeout-error
sachaarbonel Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/stream_feed/lib/src/core/error/stream_feeds_error.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,8 @@ class StreamFeedsNetworkError extends StreamFeedsError {
factory StreamFeedsNetworkError.fromDioError(DioError error) {
final response = error.response;
ErrorResponse? errorResponse;
final data = json.decode(response?.data);
if (data != null) {
errorResponse = ErrorResponse.fromJson(data);
if (response?.data != null) {
errorResponse = ErrorResponse.fromJson(json.decode(response!.data));
}
return StreamFeedsNetworkError.raw(
code: errorResponse?.code ?? -1,
Expand Down
14 changes: 14 additions & 0 deletions packages/stream_feed/test/stream_feeds_error_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,20 @@ void main() {
expect(error.message, message);
});

test('time out', () {
const message = 'Connecting timed out [0ms]';
final options = RequestOptions(path: 'test-path');

final dioError = DioError(
requestOptions: options,
error: 'Connecting timed out [${options.connectTimeout}ms]',
type: DioErrorType.connectTimeout,
);
final error = StreamFeedsNetworkError.fromDioError(dioError);
expect(error, isNotNull);
expect(error.message, message);
});

test('.fromDioError', () {
const code = 333;
const statusCode = 666;
Expand Down