Add support for pasting images into composer text input #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuno-vieira
reviewed
Feb 12, 2025
| @@ -637,7 +637,8 @@ public protocol ViewFactory: AnyObject { | |||
| placeholder: String, | |||
| editable: Bool, | |||
| maxMessageLength: Int?, | |||
| currentHeight: CGFloat | |||
| currentHeight: CGFloat, | |||
| onImagePasted: ((UIImage) -> Void)? | |||
There was a problem hiding this comment.
@anh-ngquang Thanks for the PR 👍 The implementation will probably require some changes because this is a breaking change. We will take it from here once we have time. We are planning on working on this in the next sprint.
nuno-vieira
changed the base branch from
develop
to
add/allow-pasting-images-to-composer
…g-images-into-composer
6 tasks
|
New PR without breaking changes available here: #797 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Link
N/A
🎯 Goal
Allow pasting images into composer text input, which is a common feature in messaging apps.
🛠 Implementation
Allow paste action on
InputTextView, and call a closure namedonImagePastedto pass the pasted image up to theMessageComposerView, then handle the image with theimagePastedmethod onMessageComposerViewModel, which save the image to a local temporary file, create a newAddedAssetand insert it to theaddedAssetsarray.🧪 Testing
Copy an image into the clipboard and paste into message composer text input. The image should be added into the composer view the same way as choosing an image from Photo library.
🎨 Changes
Screen.Recording.2025-02-12.at.16.41.13.480.mov
☑️ Checklist