Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove swift version checks and set the required tools version to 5.7 #3547

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Remove swift version checks and set the required tools version to 5.7 #3547

merged 3 commits into from
Jan 3, 2025

Conversation

laevandus
Copy link
Contributor

🔗 Issue Links

Resolves IOS-306

🎯 Goal

Cleanup if swift checks

🧪 Manual Testing Notes

Explain how this change can be tested manually, if applicable.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Documentation has been updated in the docs-content repo

@laevandus laevandus added 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK labels Jan 2, 2025
@laevandus laevandus requested a review from a team as a code owner January 2, 2025 13:58
martinmitrevski
martinmitrevski reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have #if swift(>=5.6) check in the Package.swift file, makes sense to remove it as well.

nuno-vieira
nuno-vieira reviewed Jan 2, 2025
View reviewed changes
Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the badge as well:

image

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Passed Quality Gate passed

Issues
173 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.5% Coverage on New Code
0.1% Duplication on New Code

See analysis details on SonarQube Cloud

@laevandus laevandus merged commit 504a349 into develop Jan 3, 2025
14 checks passed
@laevandus laevandus deleted the cleanup/swift-version-checks branch January 3, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuno-vieira nuno-vieira nuno-vieira approved these changes

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees
No one assigned
Labels
🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laevandus @martinmitrevski @nuno-vieira