-
Notifications
You must be signed in to change notification settings - Fork 357
refactor(llc, core): Improve query sorts and provide defaults. #2188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
1 task
renefloor
reviewed
Apr 8, 2025
0b29458
to
afcba43
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2188 +/- ##
==========================================
+ Coverage 61.44% 61.49% +0.05%
==========================================
Files 386 388 +2
Lines 24325 24392 +67
==========================================
+ Hits 14947 15001 +54
- Misses 9378 9391 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
renefloor
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the pull request
This pull request aims to redesign sorting to be type-safe with IDE assistance. The new system uses
ComparableField
to handle comparison between different value types and introduces extension types likeUserSortKey
andChannelSortKey
for better discoverability. This ensures the same sorting logic works client-side and server-side while catching errors at compile-time instead of runtime.