refactor!(llc, core): Improve query sorts and provide defaults. #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
1 task
renefloor
reviewed
Apr 8, 2025
| /// | ||
| /// Classes that implement this mixin can be used in sorting operations | ||
| /// where the sort key is determined at runtime. | ||
| mixin ComparableFieldProvider { |
There was a problem hiding this comment.
I would just make this an abstract interface class, because a mixin usually has functionality and not just an interface. A mixin you also use with with, for example class Musician extends Performer with Musical, but in our code it's always used with implements, so just as an interface.
Suggested change
| mixin ComparableFieldProvider { | |
| abstract interface class ComparableFieldProvider { |
There was a problem hiding this comment.
Can you extract all the sorting logic out of requests.dart? For example sort_option.dart. The file is getting quite big and this is now not only usable for requests, but also in other parts of the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the pull request
This pull request aims to redesign sorting to be type-safe with IDE assistance. The new system uses
ComparableFieldto handle comparison between different value types and introduces extension types likeUserSortKeyandChannelSortKeyfor better discoverability. This ensures the same sorting logic works client-side and server-side while catching errors at compile-time instead of runtime.