Skip to content

refactor(llc, core): Improve query sorts and provide defaults. #2188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 9, 2025

Conversation

xsahil03x
Copy link
Member

Description of the pull request

This pull request aims to redesign sorting to be type-safe with IDE assistance. The new system uses ComparableField to handle comparison between different value types and introduces extension types like UserSortKey and ChannelSortKey for better discoverability. This ensures the same sorting logic works client-side and server-side while catching errors at compile-time instead of runtime.

@xsahil03x xsahil03x linked an issue Apr 7, 2025 that may be closed by this pull request
1 task
@xsahil03x xsahil03x changed the title refactor!(llc, core): Improve query sorts and provide defaults. refactor(llc, core): Improve query sorts and provide defaults. Apr 8, 2025
@xsahil03x xsahil03x force-pushed the refactor/improve-sort-options branch from 0b29458 to afcba43 Compare April 8, 2025 22:08
@xsahil03x xsahil03x requested a review from renefloor April 8, 2025 22:09
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 70.53571% with 33 lines in your changes missing coverage. Please review.

Project coverage is 61.49%. Comparing base (0e56281) to head (8b73b52).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...r_core/lib/src/stream_channel_list_controller.dart 0.00% 8 Missing ⚠️
...er_core/lib/src/stream_member_list_controller.dart 0.00% 7 Missing ⚠️
...core/lib/src/stream_poll_vote_list_controller.dart 0.00% 7 Missing ⚠️
...tter_core/lib/src/stream_user_list_controller.dart 0.00% 7 Missing ⚠️
...stream_chat/lib/src/core/models/channel_model.dart 0.00% 2 Missing ⚠️
...lib/src/stream_message_search_list_controller.dart 0.00% 1 Missing ⚠️
...stence/lib/src/stream_chat_persistence_client.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2188      +/-   ##
==========================================
+ Coverage   61.44%   61.49%   +0.05%     
==========================================
  Files         386      388       +2     
  Lines       24325    24392      +67     
==========================================
+ Hits        14947    15001      +54     
- Misses       9378     9391      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xsahil03x xsahil03x merged commit 83bba81 into master Apr 9, 2025
15 checks passed
@xsahil03x xsahil03x deleted the refactor/improve-sort-options branch April 9, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom sort function for StreamChannelListView
2 participants