Skip to content

Migrate deprecated accompanist libraries and remove unused dependencies. #5709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 14, 2025
Merged

Migrate deprecated accompanist libraries and remove unused dependencies. #5709

merged 5 commits into from
Apr 14, 2025

Conversation

VelikovPetar
Copy link
Contributor

🎯 Goal

  • The accompanist.pager library is deprecated, and the HorizontalPager is already part of androidx.compose.foundation. This PR migrates the deprecated one to the official HorizontalPager.
  • Additionally, removes the accompanist.pager and accompanist.systemuicontroller (which was not used) dependencies.
  • Fixes compilation errors in the -uitests module.
Screenshot 2025-04-03 at 15 50 35

🛠 Implementation details

  • Migrate com.google.accompanist.pager.HorizontalPager to androidx.compose.foundation.pager.HorizontalPager
  • Remove dependencies from libs.versions.toml and the projects

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025 •
edited
Loading

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 3.16 MB 3.16 MB 0.00 MB 🟢
stream-chat-android-offline 3.38 MB 3.38 MB 0.00 MB 🟢
stream-chat-android-ui-components 7.89 MB 7.89 MB 0.00 MB 🟢
stream-chat-android-compose 9.94 MB 9.90 MB -0.04 MB 🚀

@VelikovPetar VelikovPetar marked this pull request as ready for review April 3, 2025 14:32
@VelikovPetar VelikovPetar requested a review from a team as a code owner April 3, 2025 14:32
JcMinarro
JcMinarro reviewed Apr 8, 2025
View reviewed changes
JcMinarro
JcMinarro reviewed Apr 8, 2025
View reviewed changes
@JcMinarro JcMinarro enabled auto-merge (squash) April 14, 2025 11:29
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@JcMinarro JcMinarro merged commit 786c8c0 into develop Apr 14, 2025
13 of 14 checks passed
@JcMinarro JcMinarro deleted the feature/remove-accompanist-pager branch April 14, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andremion andremion andremion approved these changes

@JcMinarro JcMinarro JcMinarro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VelikovPetar @JcMinarro @andremion