Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPI-3668 SP3 header stated values vs content checks, and ORB_TYPE update on performing Helmert transformation #64

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

treefern
Copy link
Collaborator

@treefern treefern commented Dec 23, 2024

This PR is intended to add a bit more robustness to our generated SP3 headers.

This adds:

  • Checks that the list of SVs the header claims the SP3 data contains, match the values in the DataFrame itself (which will become the content of the SP3 file written out).
  • Logic to set the ORB_TYPE field of the SP3 header to HLM, when a Helmert transformation is performed on the SP3 DataFrame. This is done to keep the header metadata used to write out headers, more consistent with changes made to the data itself.
  • Some additional unit test assertions relating to header SV count and SV list length, and merging of SV accuracy codes (lowest common denominator, in effect).
  • Various clarifying comments and variable name changes

…Vs the header states, does not match how many are read in
…n the header, and the number the header claims are there, in dataframe header metadata, so it can be easily checked by the header generator to validate consistency with the number of SVs in the dataframe. Added some clarifying comments to header generation
@treefern treefern requested a review from ronaldmaj December 23, 2024 06:29
@treefern treefern self-assigned this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant