NPI-3655 Improve readability of getVelPoly() function #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iptive variable names
seballgeyer
reviewed
Dec 18, 2024
treefern
commented
Dec 19, 2024
seballgeyer
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
More a look into this function, obscurer it looks...
it seems that the 20 lines functions is doing something that numpy can do by itself in 2 or 3 function calls.
I would suggest to merge this PR and eventually rewrite this function later. The objectives of renaming some variable to improve understanding has been achieved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes, but a bunch of renamed variables to hopefully make it clearer what this function is doing.