NPI-3655 Bring in remove_offline_sats(), add option in SP3 diff processing to avoid crashing cubic interpolator for velocity #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… general SP3 processing. Add option to remove offline sats when diffing SP3s, to avoid cubic velocity interpolator crashes. Add warning when using the cubic interpolator but not removing offline sats.
seballgeyer
requested changes
Dec 18, 2024
gnssanalysis/gn_io/sp3.py
Outdated
| @@ -191,6 +191,23 @@ def sp3_clock_nodata_to_nan(sp3_df: _pd.DataFrame) -> None: | |||
| sp3_df.loc[nan_mask, ("EST", "CLK")] = _np.nan | |||
|
|
|||
|
|
|||
| def remove_offline_sats(sp3_df: _pd.DataFrame): | |||
There was a problem hiding this comment.
Can we have an unit test on this one to make sure it works as expected?
Needs maybe 2 epochs, 2 satellite one with 0.
…in both raw and NaN forms. Add logging of whether sats were removed or not, and which ones
…n logs about offline sat removal within diff_sp3_rac
|
Further testing revealed this wasn't working as intended, due to only handling the raw representation of POS nodata, not handling |
… based on PR review
seballgeyer
approved these changes
Dec 20, 2024
treefern
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in
remove_offline_sats()from the other codebase, and adds options todiff_sp3_rac()to remove offline / partial nodata sats before running an SP3 diff. This is important becauseNaN/ non-finite position data crashes the cubic interpolator used for velocity calculations.A warning is now logged when using the cubic interpolator but not also enabling the option to remove offline sats.