Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPI-3547 Attempt to address SP3 flag rendering related crash #59

Merged
merged 3 commits into from
Nov 5, 2024
Merged

NPI-3547 Attempt to address SP3 flag rendering related crash #59

merged 3 commits into from
Nov 5, 2024

Conversation

treefern
Copy link
Collaborator

This change:

  • Adds checks for SP3 flag values (during SP3 writing).
  • Makes datatypes explicit while concatenating flags into a single column for rendering reasons. Hopefully a recent crash related to that will be addressed by this change (see corresponding ticket number for details).

@treefern treefern self-assigned this Oct 16, 2024
ronaldmaj
ronaldmaj approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@ronaldmaj ronaldmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! A nice check on the flags and ensuring that the file information should follow conventions. Talked with @treefern about his testing process. Happy for this to go in 👍

@treefern treefern merged commit 848d383 into main Nov 5, 2024
4 checks passed
@treefern treefern deleted the NPI-3547-address-sp3-flag-rendering-failure branch November 5, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldmaj ronaldmaj ronaldmaj approved these changes

@umma-zannat umma-zannat Awaiting requested review from umma-zannat

@EugeneDu-GA EugeneDu-GA Awaiting requested review from EugeneDu-GA

Assignees

@treefern treefern

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@treefern @ronaldmaj