Skip to content

Conversation

@abradley60
Copy link
Collaborator

@abradley60 abradley60 commented Oct 31, 2025

  • Adding doc string for cop30 function
  • Converting bounds and BoundingBox logic to (left, bottom, right, top)
  • Removing shape/polygon related logic for antimeridians
  • The assumption is a correct set of bounds for the antimeridian has left > right
  • If a set of bounds seems like it may cross the antimeridian, a warning is raised (see README.md)
  • Branch has been tested with antimeridian scene insar-pipeline
  • Adding a specific test for an antimeridian DEM
  • Fixing a bug where the shape of an antimeridian dem returned is different than a regular dem. I.e. when antimeridian a (1,X,Y) dem is returned when a (X,Y) dem shape should be returned from the function.

@abradley60 abradley60 self-assigned this Oct 31, 2025
@abradley60 abradley60 marked this pull request as draft October 31, 2025 06:16
@abradley60
Copy link
Collaborator Author

TODO - Add a specific test for comparing a DEM over the antimeridian

@abradley60
Copy link
Collaborator Author

TODO - Add a specific test for comparing a DEM over the antimeridian

Done ✅

@abradley60 abradley60 marked this pull request as ready for review November 3, 2025 04:28
Copy link
Collaborator

@caitlinadams caitlinadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I've made a few minor suggestions, and added a comment indicating where we may need to check that a modified set of bounds still falls within the valid extent ranges: y = (-90, 90), x = (-180, 180)

Copy link
Collaborator

@caitlinadams caitlinadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I think there's still a few of my suggestions that haven't been accepted. I've also suggested we remove the unicode ticks, since I don't think we use them elsewhere.

abradley60 and others added 5 commits November 6, 2025 09:26
Co-authored-by: Caitlin Adams <[email protected]>
Co-authored-by: Caitlin Adams <[email protected]>
@abradley60 abradley60 merged commit 747cf32 into main Nov 6, 2025
3 checks passed
@abradley60 abradley60 deleted the upgrade/improved_antimeridian_logic branch November 6, 2025 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants