Skip to content

[Fixes #13067] Thesaurus: improve management commands #13082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

etj
Copy link
Contributor

@etj etj commented Apr 14, 2025

New management command datailed in #13067

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@etj etj self-assigned this Apr 14, 2025
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Apr 14, 2025
@etj etj linked an issue Apr 14, 2025 that may be closed by this pull request
@etj etj force-pushed the 13067_thesaurus_command branch from c9a9dcf to c2b9b19 Compare April 14, 2025 15:59
@etj etj force-pushed the 13067_thesaurus_command branch from c2b9b19 to b23581c Compare April 14, 2025 16:15
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 11.36364% with 234 lines in your changes missing coverage. Please review.

Project coverage is 67.79%. Comparing base (8eb10ca) to head (b23581c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13082      +/-   ##
==========================================
- Coverage   67.80%   67.79%   -0.01%     
==========================================
  Files         977      979       +2     
  Lines       57282    57356      +74     
  Branches     6604     6621      +17     
==========================================
+ Hits        38838    38887      +49     
- Misses      16884    16908      +24     
- Partials     1560     1561       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@giohappy giohappy merged commit ebd97b3 into master Apr 15, 2025
15 of 17 checks passed
@giohappy giohappy deleted the 13067_thesaurus_command branch April 15, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thesaurus: improve management commands
2 participants