Skip to content

fix(quick-router): route "what did/have you change(d)" to action_history - #918

Open
Yurii214 wants to merge 1 commit into
GeniePod:mainfrom
Yurii214:fix/action-history-change-verb
Open

fix(quick-router): route "what did/have you change(d)" to action_history#918
Yurii214 wants to merge 1 commit into
GeniePod:mainfrom
Yurii214:fix/action-history-change-verb

Conversation

@Yurii214

@Yurii214 Yurii214 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

asks_action_history (the action_history matcher) covered the do-verb pair "what did you do" / "what have you done" and the intransitive "what changed", but not the transitive change-verb pair — so a user asking what the assistant altered fell through to the LLM:

utterance on main expected
what did you change ABSTAIN (LLM) action_history
What have you changed? ABSTAIN action_history
Jared: What did you change? ABSTAIN action_history

what did you do / what have you done / what changed already route to action_history today.

Changes

  • Add "what did you change" / "what have you changed" to the asks_action_history needle set, alongside the existing do-verb pair.
  • Negatives are unaffected (verified): "what changed in the garage today"memory_recall (the changed in the garage guard + household-note lane still win); "who changed the thermostat", "did you change the temperature", "can you change the lights" → unchanged (none contain the two new needles).
  • Add routes_change_verb_action_history_questions (both forms + a speaker-prefixed form).

Real Behavior Proof

  • I have built and run the affected code locally (or noted why I could not).
  • I have verified the change end-to-end on Jetson hardware.
  • I have NOT verified on Jetson hardware, and I explain the equivalent verification path or validation gap below.

Tested profile / hardware (check all that apply):

  • jetson
  • raspberry_pi
  • portable_sbc
  • laptop
  • mac
  • CI-only / docs-only
  • Not run locally

Ran cargo test -p genie-core --no-default-features --lib tools::quick (119 passed); the new routes_change_verb_action_history_questions test fails on main (the phrasings route to None → panic) and passes with the change. cargo fmt --all -- --check and cargo clippy (0 warnings) are clean. Pure text-classification logic, no hardware dependency, so the laptop run exercises the full affected path.

Summary by CodeRabbit

  • New Features
    • Improved action-history requests to recognize additional phrasing, including “what did you change” and “what have you changed.”
    • Supports these questions in both direct and speaker-prefixed formats.

asks_action_history matched the do-verb pair ("what did you do" / "what have
you done") and the intransitive "what changed", but not the transitive
change-verb pair, so "what did you change" / "what have you changed" fell
through to the llm. add them to the needle set, the same parity the do-verb
pair already has. negatives are unaffected (the garage guard and the
household-note lane still win, and bare "you change" is not a needle).
@github-actions github-actions Bot added the bug Something isn't working label Jul 30, 2026
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 591ccbc7-d466-48bc-9f74-e36f9d07c70e

📥 Commits

Reviewing files that changed from the base of the PR and between 02a577d and 121a0a0.

📒 Files selected for processing (1)
  • crates/genie-core/src/tools/quick.rs

📝 Walkthrough

Walkthrough

The deterministic quick router now maps “what did you change” and “what have you changed” to action_history, including speaker-prefixed forms, with corresponding unit test coverage.

Changes

Action-history routing

Layer / File(s) Summary
Change-phrase routing and coverage
crates/genie-core/src/tools/quick.rs
The router recognizes additional change-focused phrases, and tests validate plain and “Jared:” prefixed variants.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: matedev01, jeffrey701, ultrahighsuper

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding quick-router handling for change-verb questions to route to action_history.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant