fix(quick-router): route "what did/have you change(d)" to action_history - #918
Open
Yurii214 wants to merge 1 commit into
Open
fix(quick-router): route "what did/have you change(d)" to action_history#918Yurii214 wants to merge 1 commit into
Yurii214 wants to merge 1 commit into
Conversation
asks_action_history matched the do-verb pair ("what did you do" / "what have
you done") and the intransitive "what changed", but not the transitive
change-verb pair, so "what did you change" / "what have you changed" fell
through to the llm. add them to the needle set, the same parity the do-verb
pair already has. negatives are unaffected (the garage guard and the
household-note lane still win, and bare "you change" is not a needle).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe deterministic quick router now maps “what did you change” and “what have you changed” to ChangesAction-history routing
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asks_action_history(theaction_historymatcher) covered the do-verb pair"what did you do"/"what have you done"and the intransitive"what changed", but not the transitive change-verb pair — so a user asking what the assistant altered fell through to the LLM:mainwhat did you changeaction_historyWhat have you changed?action_historyJared: What did you change?action_historywhat did you do/what have you done/what changedalready route toaction_historytoday.Changes
"what did you change"/"what have you changed"to theasks_action_historyneedle set, alongside the existing do-verb pair."what changed in the garage today"→memory_recall(thechanged in the garageguard + household-note lane still win);"who changed the thermostat","did you change the temperature","can you change the lights"→ unchanged (none contain the two new needles).routes_change_verb_action_history_questions(both forms + a speaker-prefixed form).Real Behavior Proof
Tested profile / hardware (check all that apply):
jetsonraspberry_piportable_sbclaptopmacRan
cargo test -p genie-core --no-default-features --lib tools::quick(119 passed); the newroutes_change_verb_action_history_questionstest fails onmain(the phrasings route toNone→ panic) and passes with the change.cargo fmt --all -- --checkandcargo clippy(0 warnings) are clean. Pure text-classification logic, no hardware dependency, so the laptop run exercises the full affected path.Summary by CodeRabbit