Skip to content

[MISC] Lazy memory allocation for hibernation.#2973

Closed
duburcqa wants to merge 1 commit into
Genesis-Embodied-AI:mainfrom
duburcqa:lazy_mem_hibernation
Closed

[MISC] Lazy memory allocation for hibernation.#2973
duburcqa wants to merge 1 commit into
Genesis-Embodied-AI:mainfrom
duburcqa:lazy_mem_hibernation

Conversation

@duburcqa

Copy link
Copy Markdown
Collaborator

No description provided.

@duburcqa duburcqa requested a review from YilingQiao as a code owner June 22, 2026 06:14

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

self.dofs_state_adjoint_cache = get_dofs_state(solver)
self.links_state_adjoint_cache = get_links_state(solver)

P1 Badge Pass kinematic_only when building adjoint caches

When requires_grad is enabled, this branch still calls get_dofs_state and get_links_state with only solver, but this change made both helpers require the new kinematic_only argument. Any differentiable rigid simulation now fails during DataManager construction with a TypeError before it can initialize; pass the flag here (likely False for these rigid adjoint caches) or give the helper a default.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@duburcqa duburcqa force-pushed the lazy_mem_hibernation branch from cb3b0f8 to 4c4109d Compare June 22, 2026 07:43
@github-actions

Copy link
Copy Markdown

🔴 Benchmark Regression Detected ➡️ Report

@duburcqa duburcqa closed this Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant