[MISC] Lazy memory allocation for hibernation.#2973
Conversation
There was a problem hiding this comment.
💡 Codex Review
genesis-world/genesis/utils/array_class.py
Lines 2305 to 2306 in cb3b0f8
When requires_grad is enabled, this branch still calls get_dofs_state and get_links_state with only solver, but this change made both helpers require the new kinematic_only argument. Any differentiable rigid simulation now fails during DataManager construction with a TypeError before it can initialize; pass the flag here (likely False for these rigid adjoint caches) or give the helper a default.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
cb3b0f8 to
4c4109d
Compare
|
🔴 Benchmark Regression Detected ➡️ Report |
No description provided.