Figure.set_panel: Migrate the 'panel' parameter to the new alias system #4175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
maintenance
seisman
commented
Oct 23, 2025
pygmt/src/subplot.py
Outdated
| module="subplot", | ||
| args=[ | ||
| "set", | ||
| _to_string(panel, sep=",", size=2), |
Member
Author
There was a problem hiding this comment.
We can't directly use the Alias/AliasSystem classes like in other wrappers, because panel is an argument of a GMT option. The GMT CLI syntax is:
gmt subplot set <panel>
so we have to use the private _to_string method here.
Member
Author
There was a problem hiding this comment.
Not ideal. Converting to draft PR.
Member
Author
There was a problem hiding this comment.
so we have to use the private
_to_stringmethod here.
Now using Alias._value instead.
seisman
added
final review call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.