-
Notifications
You must be signed in to change notification settings - Fork 229
SPEC 0: Bump minimum supported version to NumPy 2.0 #4090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
https://github.com/GenericMappingTools/pygmt/actions/runs/17768889118/job/50499354183?pr=4090
Likely need to bump xarray first. See #4091. The Python 3.11 CI job has two failing tests due to the removal of the
|
d14b09a
to
70c70c3
Compare
70c70c3
to
5ce69a2
Compare
There is a numpy<2.0 pin set at conda-forge/conda-forge-repodata-patches-feedstock#728, we might need to bump xarray higher, to 2024.5.0 I think? |
Still failing. The minimum xarray version compatible with numpy 2.0 is xarray 2024.5:
I guess we need to either bump to xarray 2024.5 now or wait until 2026 quarter 2. |
xarray=2024.06.0 according to numpy/numpy#26191 (comment) (unsure if it's the repodata patch that's wrong, or that linked thread is wrong, but I did find pydata/xarray#8946). How about we delay the numpy 2.0+ bump for another quarter, i.e. leave this PR in draft until November/December 2025? |
Following SPEC0 policy, NumPy 1.26 should be dropped in 2025 quarter 3.
Bumps the minimum supported NumPy version to 2.0 in the following files:
.github/workflows/ci_tests.yaml
.github/workflows/ci_tests_legacy.yaml
environment.yml
pyproject.toml
requirements.txt
Supersedes #3916.