-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyarrow: Check compatibility of pyarrow.array with string type #2933
Merged
Merged
Changes from 23 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
1f32a7c
Check passing pyarrow.array with string type to pygmt.text
weiji14 4c4e064
Check passing pyarrow.array with string type to virtualfile_from_vectors
weiji14 07fbca6
Merge branch 'main' into pyarrow/string
weiji14 d379e46
Enable passing pyarrow.StringArray to clib.Session.put_strings
weiji14 cfda386
Use "string" instead of pyarrow.string() in case pyarrow not installed
weiji14 0a6cda5
Try to fix type hints
weiji14 f59f93c
Add np.ndarray to StringArrayTypes and fix/ignore remaining type errors
weiji14 757da24
Merge branch 'main' into pyarrow/string
weiji14 17c1e9c
Move StringArrayTypes to pygmt/_typing.py
weiji14 0105d64
Add pyarrow to docs CI
weiji14 3ad0c86
Use np.asarray to convert pa.StringArray instead of .to_pylist()
weiji14 4bea288
Update note to say that PyArrow string types are now supported
weiji14 371174a
Add back pytest.mark.benchmark marker
weiji14 b588730
Add intersphinx link for pyarrow
weiji14 faf2065
Apply suggestions from code review
weiji14 b2efbb4
Merge branch 'main' into pyarrow/string
weiji14 9fd77dc
format
weiji14 ccf4eff
Merge branch 'main' into pyarrow/string
weiji14 44d01ed
Merge branch 'main' into pyarrow/string
weiji14 a927202
Revert "Enable passing pyarrow.StringArray to clib.Session.put_strings"
weiji14 7b00248
Reduce diff from messy revert handling
weiji14 7dc353b
Revert support of pyarrow.array inputs to put_strings
weiji14 ce76152
Remove StringArrayTypes type hint
weiji14 ef431af
Revert "Remove StringArrayTypes type hint"
weiji14 acaf350
Improve type-hint of text parameter in pygmt.Figure.text
weiji14 6ad6eb9
Move pa.array parametrizations to another file
weiji14 d88accd
Pass a tuple of vectors to virtualfile_from_vectors
weiji14 265132e
Move skip_if_no and pyarrow import to test_clib_virtualfile_from_vectors
weiji14 edb3438
The text argument can be None
weiji14 8172102
Simplify to remove getattr(pa, "array", None) call
weiji14 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test was moved to
test_clib_virtualfile_from_vectors
in #3512.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved in 6ad6eb9