Refactor test_image to plot @circuit.png instead of test_logo.png #2922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we don't need to pull test_logo.png from dvc, or run test_logo first to generate the image.
weiji14
added
maintenance
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)Added imagesModified images
Report last updated at commit 121e589 |
seisman
approved these changes
Dec 27, 2023
weiji14
commented
Dec 27, 2023
pygmt/tests/test_image.py
Outdated
| import sys | ||
|
|
||
| import pytest | ||
| from pygmt import Figure | ||
|
|
||
| TEST_IMG = os.path.join(os.path.dirname(__file__), "baseline", "test_logo.png") | ||
|
|
||
|
|
||
| @pytest.mark.skipif(sys.platform == "win32", reason="crashes on Windows") |
There was a problem hiding this comment.
Gonna try removing this line and see if it still crashes on Windows. Xref #518 (comment).
There was a problem hiding this comment.
Oo, test_image no longer crashes on Windows with GMT 6.3 (see https://github.com/GenericMappingTools/pygmt/actions/runs/7334833328/job/19971998592?pr=2922#step:7:508) and GMT 6.4 (see https://github.com/GenericMappingTools/pygmt/actions/runs/7334833574/job/19971999909?pr=2922#step:8:473) 🎉
|
Marking as 'ready for review' to run tests on Windows. Still need to revert the uncommented |
7 tasks
This reverts commit afe2d23.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
So that we don't need to pull test_logo.png from dvc, or run test_logo first to generate the image.
The circuit.png file is from https://github.com/GenericMappingTools/gmtserver-admin/blob/master/cache/circuit.png
Fixes #2911 (comment), patches #2079 (comment), fixes #518 (comment)
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version