-
Notifications
You must be signed in to change notification settings - Fork 50
feat(trace): SequenceDetector primitive - session-window multi-step attack detection #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 7 commits
e9a575d
de48021
9b2b476
ac36d6a
c8b4dc3
62fae0f
0f18488
a83bd01
fd7a9b3
c0682af
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,233 @@ | ||
| """Sequence Detector | ||
|
|
||
| Detects multi-step attack patterns across a session or workflow window. | ||
| Challenge authors configure this in YAML with no Python required. | ||
| """ | ||
|
|
||
| import fnmatch | ||
| import json | ||
| import logging | ||
| import re | ||
| from datetime import UTC, datetime, timedelta | ||
| from typing import Any, NotRequired, TypedDict | ||
|
|
||
| from sqlalchemy.orm import Session | ||
|
|
||
| from finbot.core.data.models import CTFEvent | ||
| from finbot.ctf.detectors.base import BaseDetector | ||
| from finbot.ctf.detectors.registry import register_detector | ||
| from finbot.ctf.detectors.result import DetectionResult | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class StepSpec(TypedDict): | ||
| event_type: str # Glob pattern, e.g. "agent.*.tool_call_success" | ||
| label: str # Human-readable name for evidence output | ||
| conditions: NotRequired[dict[str, Any]] # ToolCallDetector operators | ||
|
|
||
|
|
||
| @register_detector("SequenceDetector") | ||
| class SequenceDetector(BaseDetector): | ||
| """Detects multi-step attack patterns across a session window. | ||
|
|
||
| Configuration: | ||
| steps: list[StepSpec] -- ordered sequence to match | ||
| within_n_events: int -- max events between steps (default: unlimited) | ||
| within_seconds: int -- optional time-based window (default: unlimited) | ||
| order_matters: bool -- enforce step ordering (default: true) | ||
| window: "session" | "workflow" -- scope for history query (default: "session") | ||
|
|
||
| StepSpec fields: | ||
| event_type: str -- glob pattern, e.g. "agent.*.tool_call_success" | ||
| conditions: dict -- field conditions using ToolCallDetector operators | ||
| label: str -- human-readable name for evidence output | ||
|
|
||
| Example YAML: | ||
| detector_class: SequenceDetector | ||
| detector_config: | ||
| steps: | ||
| - event_type: "agent.*.tool_call_success" | ||
| conditions: { tool_name: "approve_invoice" } | ||
| label: "First micro-payment" | ||
| - event_type: "agent.*.tool_call_success" | ||
| conditions: { tool_name: "approve_invoice" } | ||
| label: "Second micro-payment" | ||
| within_n_events: 50 | ||
| within_seconds: 300 | ||
| order_matters: true | ||
| window: "session" | ||
| """ | ||
|
|
||
| def _validate_config(self) -> None: | ||
| steps = self.config.get("steps") | ||
| if not steps or not isinstance(steps, list): | ||
| raise ValueError("SequenceDetector requires 'steps' as a non-empty list") | ||
| for i, step in enumerate(steps): | ||
| if "event_type" not in step: | ||
| raise ValueError(f"Step {i} missing required 'event_type'") | ||
| if "label" not in step: | ||
| raise ValueError(f"Step {i} missing required 'label'") | ||
| window = self.config.get("window", "session") | ||
| if window not in ("session", "workflow"): | ||
| raise ValueError("window must be 'session' or 'workflow'") | ||
|
|
||
| def get_relevant_event_types(self) -> list[str]: | ||
| steps: list[StepSpec] = self.config.get("steps", []) | ||
| return [step["event_type"] for step in steps] | ||
|
|
||
| async def check_event(self, event: dict[str, Any], db: Session) -> DetectionResult: | ||
| steps: list[StepSpec] = self.config.get("steps", []) | ||
| within_n = self.config.get("within_n_events") | ||
| within_seconds = self.config.get("within_seconds") | ||
| order_matters = self.config.get("order_matters", True) | ||
| window = self.config.get("window", "session") | ||
|
|
||
| namespace = event.get("namespace") | ||
|
|
||
| if window == "workflow": | ||
| window_id = event.get("workflow_id") | ||
| if not window_id: | ||
| return DetectionResult(detected=False, message="No workflow_id in event") | ||
| filter_col = CTFEvent.workflow_id | ||
| else: | ||
| window_id = event.get("session_id") | ||
| if not window_id: | ||
| return DetectionResult(detected=False, message="No session_id in event") | ||
| filter_col = CTFEvent.session_id | ||
|
|
||
| query = db.query(CTFEvent).filter( | ||
| CTFEvent.namespace == namespace, | ||
| filter_col == window_id, | ||
| ) | ||
|
|
||
| if within_seconds is not None: | ||
| event_time = event.get("timestamp") | ||
| if isinstance(event_time, str): | ||
| event_time = datetime.fromisoformat(event_time.replace("Z", "+00:00")) | ||
| elif not isinstance(event_time, datetime): | ||
| event_time = datetime.now(UTC) | ||
| cutoff = event_time - timedelta(seconds=within_seconds) | ||
| query = query.filter(CTFEvent.timestamp >= cutoff) | ||
|
|
||
| if within_n is not None: | ||
| history = ( | ||
| query.order_by(CTFEvent.timestamp.desc()) | ||
| .limit(within_n) | ||
| .all() | ||
| ) | ||
| history = list(reversed(history)) | ||
| else: | ||
| history = query.order_by(CTFEvent.timestamp.asc()).all() | ||
|
|
||
| matched: list[dict[str, Any]] = [] | ||
| search_from = 0 | ||
|
|
||
| for step in steps: | ||
| found_at = None | ||
| for i in range(search_from, len(history)): | ||
| if self._matches_step(history[i], step): | ||
| found_at = i | ||
| break | ||
|
|
||
| if found_at is None: | ||
| return DetectionResult( | ||
| detected=False, | ||
| message=f"Sequence incomplete: step '{step['label']}' not matched", | ||
| evidence={ | ||
| "matched_steps": matched, | ||
| "missing_step": step["label"], | ||
| "window": window, | ||
| "window_id": window_id, | ||
| }, | ||
| ) | ||
|
|
||
| matched.append( | ||
| { | ||
| "step": step["label"], | ||
| "event_id": history[found_at].id, | ||
| "event_type": history[found_at].event_type, | ||
| } | ||
| ) | ||
| if order_matters: | ||
| search_from = found_at + 1 | ||
|
|
||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Lines: 132–162 When order_matters=False, search_from stays at 0 for every step. This means each step scans the full history independently from the beginning. If a single event matches two different steps (e.g. event_type = "agent.*.tool_call_success" with no conditions), it will satisfy both step 1 and step 2 on its own, making a 2-step sequence trigger from just 1 event. In a CTF, this is exploitable. Track which history indices have already been consumed and skip them for subsequent steps. Once an event is matched to a step, mark it as consumed so no other step can claim it |
||
| return DetectionResult( | ||
| detected=True, | ||
| confidence=1.0, | ||
| message=f"Multi-step sequence detected: {[m['step'] for m in matched]}", | ||
| evidence={ | ||
| "matched_steps": matched, | ||
| "window": window, | ||
| "window_id": window_id, | ||
| "step_count": len(matched), | ||
| }, | ||
| ) | ||
|
|
||
| def _matches_step(self, ctf_event: CTFEvent, step: StepSpec) -> bool: | ||
| """Check if a CTFEvent matches a step spec.""" | ||
| if not fnmatch.fnmatch(ctf_event.event_type, step["event_type"]): | ||
| return False | ||
|
|
||
| conditions = step.get("conditions", {}) | ||
| if not conditions: | ||
| return True | ||
|
|
||
| details: dict[str, Any] = {} | ||
| if ctf_event.details: | ||
| try: | ||
| details = json.loads(ctf_event.details) | ||
| except (json.JSONDecodeError, TypeError): | ||
| pass | ||
|
|
||
| # Known CTFEvent column names that can be matched directly | ||
| _ctf_columns = frozenset({ | ||
| "event_type", "event_category", "event_subtype", | ||
| "session_id", "workflow_id", "namespace", "user_id", | ||
| "vendor_id", "agent_name", "tool_name", "severity", | ||
| }) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. line 193 - 197 The frozenset({...}) literal with 10 strings is created fresh every single time _matches_step is called. Since this runs inside the step-matching loop (once per event × once per step in history), it adds unnecessary allocation overhead. It's not a bug, but it's wasteful. Move it to a module-level constant: At module level, near the top of the file |
||
|
|
||
| for field, condition in conditions.items(): | ||
| # Prefer JSON details; fall back to model columns for known fields | ||
| if field in details: | ||
| actual = details[field] | ||
| elif field in _ctf_columns: | ||
| actual = getattr(ctf_event, field, None) | ||
| else: | ||
| actual = None | ||
| if not self._check_condition(actual, condition): | ||
| return False | ||
|
|
||
| return True | ||
|
|
||
| def _check_condition(self, actual: Any, condition: Any) -> bool: | ||
| """Check if actual value satisfies condition (ToolCallDetector operators).""" | ||
| if not isinstance(condition, dict): | ||
| return actual == condition | ||
|
|
||
| for operator, expected in condition.items(): | ||
| op = operator.lower() | ||
| if op == "exists": | ||
| return (actual is not None) == expected | ||
| if actual is None: | ||
| return False | ||
| if op in ("equals", "eq"): | ||
| return actual == expected | ||
| if op == "in": | ||
| return actual in expected | ||
| if op == "not_in": | ||
| return actual not in expected | ||
| if op == "contains": | ||
| return expected in str(actual).lower() | ||
| if op == "gt": | ||
| return float(actual) > float(expected) | ||
| if op == "gte": | ||
| return float(actual) >= float(expected) | ||
| if op == "lt": | ||
| return float(actual) < float(expected) | ||
| if op == "lte": | ||
| return float(actual) <= float(expected) | ||
| if op == "matches": | ||
| return bool(re.search(expected, str(actual), re.IGNORECASE)) | ||
|
|
||
| return False | ||
|
stealthwhizz marked this conversation as resolved.
Outdated
|
||
Uh oh!
There was an error while loading. Please reload this page.