fix: P16.1 file-existence + JS DSGAI20 coverage (audit M4/L5) - #52
Merged
Conversation
…udit M4/L5) - M4: P16.1 was a dead rule — a filename-existence check the CLI never implemented (content-grep only), so DSGAI16 PASS was unreachable. Add a 'match: file_exists' rule mode: the presence of a matching file IS the signal. P16.1 now fires on an .aiignore fixture -> DSGAI16 = PASS. Schema, regen tool, and Semgrep export (which excludes file_exists rules) all updated. - L5: DSGAI20 rules now scan *.js/*.ts, so the unauthenticated JS /chat endpoint (fixture js-service) is caught as P20.5 FAIL. Removed the stale known_false_negative that was wrongly tagged fixed_in: PR-15. Answer sheet 32 -> 36 (P16.1 + 2x P16.2 + P20.5 js); regen --check passes; rules schema-valid; 24 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
match: file_existsmode — presence of a matching file is the signal. P16.1 now fires on an.aiignorefixture → DSGAI16 = PASS. Schema, regen tool, and Semgrep export (excludes file_exists rules) updated.*.js/*.ts, so the unauthenticated JS/chatendpoint is caught as P20.5 FAIL. Removed the staleknown_false_negative.Answer sheet 32 → 36;
regen --checkpasses; schema-valid; 24 tests pass.