fix: gitleaks keywords, semgrep multiline, variant, docs (audit M2/M5/L4/L6/L7) - #51
Merged
Conversation
…ok probe (audit M2/M5/L4/L6/L7) - M2: gitleaks keyword prefilter dropped AZURE_OPENAI_KEY / GCP_SERVICE_ACCOUNT_KEY / AWS_ACCESS_KEY_ID (none contained a listed keyword). Add 'key' — verified all three now caught. The recommended path is no longer weaker than the fallback. - L7: the Semgrep export now prepends (?m) to line-anchored patterns (P04.4) so matches on any line, not just file start, under whole-file pattern-regex. - M5: wrap the remaining Claude-Code-isms (the Grep-tool output_mode sentence, the 'parallel scans in Claude Code' timing) in cc-only markers; the generated tool-neutral variant now has zero 'Grep tool' / CC-parallel references in its body. - L6: dsgai-secret-scan.sh probes for PCRE2 support and skips loudly instead of failing open (a stripped ripgrep previously let commits pass silently). - L4: rules/README documents the requires_nearby 'pattern' key added in PR-11. shellcheck clean; semgrep + variant --check in sync; 24 pass; gitleaks 3/3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch of pack/doc/script audit fixes.
AZURE_OPENAI_KEY/GCP_SERVICE_ACCOUNT_KEY/AWS_ACCESS_KEY_ID— addedkey; verified 3/3 now caught.(?m)to line-anchored patterns (P04.4) so^matches any line.output_mode, 'parallel in Claude Code') incc-onlymarkers → the tool-neutral variant body now has 0 such references.dsgai-secret-scan.shprobes for PCRE2 and skips loudly instead of failing open.requires_nearby.pattern.shellcheck clean; semgrep+variant
--checkin sync; 24 pass.