fix: scan gitignored .env files (audit C1, critical) - #47
Merged
Conversation
Discovery used 'git ls-files --cached --others --exclude-standard', which drops gitignored+untracked files. In a real repo .env is gitignored, so the flagship value-bearing credential detection (hardcoded key in .env) silently never ran — the report showed a clean bill over a live key. The committed fixture .env (tracked) masked this in tests. Fix: union git discovery with a targeted walk for ALWAYS_SCAN_GLOBS (.env, *.env, .env.*, *.envrc) so credential files are scanned even when gitignored. Fixture scan unchanged (32 findings, exact); added a regression test with a real-world gitignored-.env repo layout (would have caught this).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Critical audit fix. Discovery honored .gitignore via git ls-files, so a normally-gitignored
.envwas never scanned — the flagship 'hardcoded key in .env' detection silently didn't run in real repos. The committed fixture .env (tracked) masked it.Fix: credential files matching
ALWAYS_SCAN_GLOBS(.env,*.env,.env.*,*.envrc) are now scanned even when gitignored. Verified: real-repo layout now catches the key (DSGAI02 FAIL); fixture scan unchanged (32, exact); regression test added.