PR-02: Repo hygiene (scanner) - #25
Merged
Merged
Conversation
…pression (PR-02) - README: add a Non-goals section (the maintainer's scope shield). - .github/CODEOWNERS: route dsgai_scanner_tool/ to @emmanuelgjr. - .github/workflows/scanner-lint.yml: path-filtered lint (shellcheck -S warning, yamllint, deterministic internal markdown-link check). All three pass locally. - scripts/check_md_links.py: dependency-free internal-link/anchor checker (no flaky external HTTP in a required gate). - .gitattributes: force LF on *.sh/*.py/*.yml/*.yaml so Windows autocrlf checkouts can't ship CRLF that breaks shellcheck/bash on Linux CI. - DSGAI-samplereport.png: 5.0 MB -> 0.35 MB (14x) interim compression; full regeneration from the fixture app lands in PR-09. dependabot already covers the github-actions ecosystem; pip is added in PR-05 with the CLI manifest. shellcheck is clean at warning level; the mapfile/grep -zE portability issues (lines 18/20) are bash-3.2/BSD concerns shellcheck can't see without shell context — deferred to PR-10 as planned. Annotated tag scanner-v0.2.0 created locally; push held for maintainer approval per plan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 0 mechanical hygiene for the DSGAI scanner. Depends on PR-01 (merged).
What's here
.github/CODEOWNERS—/dsgai_scanner_tool/ @emmanuelgjr..github/workflows/scanner-lint.yml— path-filtered todsgai_scanner_tool/**:shellcheck -S warningonintegrations/*.sh,yamllinton scanner YAML, and a deterministic internal markdown-link check. All three verified locally;actionlintclean.scripts/check_md_links.py— dependency-free internal-link/anchor checker (chosen over a third-party external-URL action, which would be a flaky required gate needing an unverifiable SHA pin)..gitattributes— forces LF on*.sh/*.py/*.yml/*.yaml. Prevents Windowsautocrlfcheckouts from shipping CRLF that breaks shellcheck/bash on Linux CI (a real failure I hit while validating).DSGAI-samplereport.png— compressed 5.0 MB → 0.35 MB (14×), valid PNG, display-neutral at the README's 800px width.Verification
shellcheck -S warning,yamllint,check_md_links.py, andactionlintall pass locally.Notes / deviations
mapfile(line 18) /grep -zE(line 20) portability bugs are bash-3.2/BSD concerns shellcheck can't detect without shell context, so there was nothing to# shellcheck disable. They're documented here and fixed in PR-10. The.shfile is intentionally left untouched (PR-10's scope).github-actionsecosystem;pipis added in PR-05 alongside the CLI manifest.scanner-v0.2.0created locally at the pre-improvement baseline; push held for your explicit approval per the plan (batched with the later release tags).Follow-ups
mapfile/grep -zEportability indsgai-secret-scan.sh.