Skip to content
This repository has been archived by the owner on May 20, 2020. It is now read-only.

Commit

Permalink
fix for when user selects sync1 option
Browse files Browse the repository at this point in the history
  • Loading branch information
GaurangTandon committed Jun 17, 2019
1 parent 7d3fefa commit 6d31016
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion js/background.js
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,7 @@ chrome.runtime.onMessage.addListener((request, sender, sendResponse) => {
localStorage[LS_STORAGE_TYPE_PROP] = targetStorage;
storage.get((response) => {
window.Data = response[OLD_DATA_STORAGE_KEY];
if (typeof Data === "undefined") {
if (typeof Data === "undefined" && !request.overridingSync) {
// reset everuthing to before
window.Data = oldData;
makeDataReady();
Expand Down
2 changes: 1 addition & 1 deletion js/commonDataHandlers.js
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ function migrateData(transferData, callback) {
Data.snippets = false;

DBupdate(() => {
chrome.runtime.sendMessage({ changeStorageType: true }, (response) => {
chrome.runtime.sendMessage({ changeStorageType: true, overridingSync: transferData }, (response) => {
if (response.completed === false) {
Data.snippets = copyOfTheOldData;
DBupdate(() => {
Expand Down
2 changes: 1 addition & 1 deletion manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"manifest_version": 2,
"name": "ProKeys",
"description": "Save time and effort in emails, etc. with ProKeys! Define snippets, do math in browser, auto complete braces, and much more.",
"version": "3.5.4",
"version": "3.5.2",
"author": "Aquila Softworks",
"browser_action": {
"default_icon": "imgs/r16.png"
Expand Down
5 changes: 3 additions & 2 deletions tests/data/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ It features several changes to default data, and the aim is that after upgrading

### Things to test in sync

1. Sync updates in one page are reflected on another within five minutes.
1. Sync updates in one page are reflected on another (after browser relaunch).
2. Too quick sync (set sync on in one pc and quickly set it in another) results in neat error message with no data loss.
3. upgrade from previous public version to next version does not cause any error.
3. Upgrade from previous public version to next version does not cause any error.
4.

0 comments on commit 6d31016

Please sign in to comment.