-
-
Notifications
You must be signed in to change notification settings - Fork 58
1.21.4 Resource Pack Support #1098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SpecialBuilder32 Have you had time to look further into these issues? Given that 1.21.5-pre1 just released, it would be ideal if this PR is ready to be merged before we have to worry with the 1.21.5 update. |
In tracking down what the load errors were, I realized there were some special cases I needed to manually handle. I had thought it was just the end fishing elytra but now that I see build errors I realize armor trims must also be redone :/ |
Covers player heads, which is used by metallurgy mould heads. NOTE: current implementation puts heads on an armor stand, bypassing the usual model rendering. If a custom block model is added to the moulds, migration to an item-display is required.
Alright just a quick update on this - after running into too many edge cases, I'm half-rewriting the 1.20.4/1.20.5 update to make more sense and handle model-file/item-definition interactions better. It'll be a fair amount of more testing and debugging until this is ready. Sorry 😢 |
f190087
to
edc07b1
Compare
Adds 1.21.4. item model definition files to the resource pack, and moves existing models to an overlay for backwards compatibility.
Remaining tasks: