Skip to content

Metallurgy 1.21: Lore Line Shrink #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

EpyonProjects
Copy link
Member

@EpyonProjects EpyonProjects commented Dec 1, 2024

Currently, Metallurgy shamir lore takes up 3 lines

Name: Obsidian Cast
Lore: <Metal Type> Band
      Shamir
      <Shamir>

This update removes that standalone "Shamir" line to only use 2 lines

Name: Obsidian Cast
Lore: <Metal Type> Band
      <Shamir> Shamir

This change is part of the larger Metallurgy redesign.
Existing items will not have " Shamir" appended to the end, but will function the same. This also means old unattached bands will not be stackable with shamirs created after this update.

@misode misode added feature-update An additional feature has been added to a module needs-testing Requires in-game testing labels Dec 1, 2024
@Bloo-dev Bloo-dev marked this pull request as draft January 19, 2025 20:09
@Bloo-dev
Copy link
Member

This is now waiting on some 1.21.5 changes.

@EpyonProjects EpyonProjects marked this pull request as ready for review March 13, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-update An additional feature has been added to a module needs-testing Requires in-game testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants