Skip to content

Fix slot export for HF NTAG 216 tags #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vidonnus wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix slot export for HF NTAG 216 tags #823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
228 changes: 218 additions & 10 deletions chameleonultragui/lib/gui/menu/dialogs/slot/export.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ class SlotExportMenu extends StatefulWidget {
class SlotExportMenuState extends State<SlotExportMenu> {
TagFrequency exportFrequency = TagFrequency.unknown;

Future<CardSave?> rebuildCardSaveFromSlot(TagFrequency frequency) async {
Future<CardSave?> rebuildCardSaveFromSlot(TagFrequency frequency,
{void Function(int current, int total)? onProgress}) async {
var appState = context.read<ChameleonGUIState>();

if (frequency == TagFrequency.lf) {
Expand Down Expand Up @@ -66,11 +67,46 @@ class SlotExportMenuState extends State<SlotExportMenu> {
if (isMifareUltralight(widget.slotTypes.hf)) {
int pageCount = mfUltralightGetPagesCount(widget.slotTypes.hf);
List<Uint8List> pages = [];
const int batchSize =
16; // Read 16 pages at a time for better performance

for (int page = 0; page < pageCount; page++) {
Uint8List pageData =
await appState.communicator!.mf0EmulatorReadPages(page, 1);
pages.add(pageData);
try {
for (int page = 0; page < pageCount; page += batchSize) {
int readCount =
(page + batchSize > pageCount) ? pageCount - page : batchSize;

try {
// Try batch read first
Uint8List batchData = await appState.communicator!
.mf0EmulatorReadPages(page, readCount);

// Split batch into individual pages (4 bytes each)
for (int i = 0; i < readCount; i++) {
pages.add(batchData.sublist(i * 4, (i + 1) * 4));
}

// Report progress
if (onProgress != null) {
onProgress(page + readCount, pageCount);
}
} catch (e) {
// Fallback to single-page reads if batch fails;
// if these also throw, the outer catch returns null
for (int i = page; i < page + readCount; i++) {
Uint8List pageData =
await appState.communicator!.mf0EmulatorReadPages(i, 1);
pages.add(pageData);

// Report progress
if (onProgress != null) {
onProgress(i + 1, pageCount);
}
}
}
}
} catch (e) {
// Return null to indicate failure
return null;
}

CardSaveExtra extraData = CardSaveExtra();
Expand Down Expand Up @@ -166,11 +202,66 @@ class SlotExportMenuState extends State<SlotExportMenu> {
var appState = Provider.of<ChameleonGUIState>(context, listen: false);
close(context, card.name);

final TagFrequency frequency = chameleonTagToFrequency(card.tag);
final bool showProgress = isMifareUltralight(frequency == TagFrequency.hf
? widget.slotTypes.hf
: widget.slotTypes.lf);

ValueNotifier<double?> progressNotifier = ValueNotifier(null);

// Only show progress dialog for Ultralight tags (the only type with pages to read)
if (showProgress && mounted) {
showDialog(
context: context,
barrierDismissible: false,
builder: (progressContext) {
return ValueListenableBuilder<double?>(
valueListenable: progressNotifier,
builder: (context, progress, child) {
return AlertDialog(
title: Text(localizations.exporting),
content: Column(
mainAxisSize: MainAxisSize.min,
children: [
LinearProgressIndicator(value: progress),
],
),
);
},
);
},
);
}

CardSave modify = card;
CardSave? newCard =
await rebuildCardSaveFromSlot(chameleonTagToFrequency(card.tag));
CardSave? newCard = await rebuildCardSaveFromSlot(
frequency,
onProgress: (current, total) {
progressNotifier.value = current / total;
},
);

// Close progress dialog
if (showProgress && mounted) {
Navigator.pop(context);
}

if (newCard == null) {
if (mounted) {
showDialog(
context: context,
builder: (dialogContext) => AlertDialog(
title: Text(localizations.error),
content: Text(localizations.failed_to_export_slot),
actions: [
ElevatedButton(
onPressed: () => Navigator.pop(dialogContext),
child: Text(localizations.ok),
),
],
),
);
}
return;
}

Expand Down Expand Up @@ -239,9 +330,65 @@ class SlotExportMenuState extends State<SlotExportMenu> {
actions: [
ElevatedButton(
onPressed: () async {
CardSave? cardSave = await rebuildCardSaveFromSlot(exportFrequency);
final bool showProgress = isMifareUltralight(
exportFrequency == TagFrequency.hf
? widget.slotTypes.hf
: widget.slotTypes.lf);

ValueNotifier<double?> progressNotifier = ValueNotifier(null);

// Only show progress dialog for Ultralight tags (the only type with pages to read)
if (showProgress) {
showDialog(
context: context,
barrierDismissible: false,
builder: (progressContext) {
return ValueListenableBuilder<double?>(
valueListenable: progressNotifier,
builder: (context, progress, child) {
return AlertDialog(
title: Text(localizations.exporting),
content: Column(
mainAxisSize: MainAxisSize.min,
children: [
LinearProgressIndicator(value: progress),
],
),
);
},
);
},
);
}

CardSave? cardSave = await rebuildCardSaveFromSlot(
exportFrequency,
onProgress: (current, total) {
progressNotifier.value = current / total;
},
);

// Close progress dialog
if (showProgress && context.mounted) {
Navigator.pop(context);
}

if (cardSave == null) {
if (context.mounted) {
showDialog(
context: context,
builder: (dialogContext) => AlertDialog(
title: Text(localizations.error),
content: Text(localizations.failed_to_export_slot),
actions: [
ElevatedButton(
onPressed: () => Navigator.pop(dialogContext),
child: Text(localizations.ok),
),
],
),
);
}
return;
}

Expand Down Expand Up @@ -271,8 +418,69 @@ class SlotExportMenuState extends State<SlotExportMenu> {
),
ElevatedButton(
onPressed: () async {
CardSave? tag = await rebuildCardSaveFromSlot(exportFrequency);
if (context.mounted && tag != null) {
final bool showProgress = isMifareUltralight(
exportFrequency == TagFrequency.hf
? widget.slotTypes.hf
: widget.slotTypes.lf);

ValueNotifier<double?> progressNotifier = ValueNotifier(null);

// Only show progress dialog for Ultralight tags (the only type with pages to read)
if (showProgress) {
showDialog(
context: context,
barrierDismissible: false,
builder: (progressContext) {
return ValueListenableBuilder<double?>(
valueListenable: progressNotifier,
builder: (context, progress, child) {
return AlertDialog(
title: Text(localizations.exporting),
content: Column(
mainAxisSize: MainAxisSize.min,
children: [
LinearProgressIndicator(value: progress),
],
),
);
},
);
},
);
}

CardSave? tag = await rebuildCardSaveFromSlot(
exportFrequency,
onProgress: (current, total) {
progressNotifier.value = current / total;
},
);

// Close progress dialog
if (showProgress && context.mounted) {
Navigator.pop(context);
}

if (tag == null) {
if (context.mounted) {
showDialog(
context: context,
builder: (dialogContext) => AlertDialog(
title: Text(localizations.error),
content: Text(localizations.failed_to_export_slot),
actions: [
ElevatedButton(
onPressed: () => Navigator.pop(dialogContext),
child: Text(localizations.ok),
),
],
),
);
}
return;
}

if (context.mounted) {
await showDialog(
context: context,
builder: (BuildContext dialogContext) {
Expand Down
2 changes: 2 additions & 0 deletions chameleonultragui/lib/l10n/app_en.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,8 @@
"save_to_file": "Save to file",
"export_to_new_card": "Export to new card",
"update_saved_card": "Update saved card",
"failed_to_export_slot": "Failed to export slot data.",
"exporting": "Exporting...",
"must_be_valid_hex": "Must be valid HEX",
"export_to_dictionary": "Export found keys",
"enter_name_of_card": "Enter name of card",
Expand Down