Fix Gamedig command for Minecraft servers #4725
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Command to output the results for player count was looking at the wrong object in the tree. This change corrects it to the right objects.
Fix/gamedig
Update to include bot count in monitor output from Gamedig.
Fixed issue where messages from different actions weren't logging correctly due to using the wrong variable in when crafting the log message
Commit changes made after pull change submiited.
The current implementation doesn't use the full file path to determine the existence of the backup directory in relation to the server which means the current stats just looks for the "lgsm/backup" directory. That may work if you're already in the root directory for the server but if you're scripting the backups via cron, you're not likely going to be invoking the backup from the root directory.
Reworked the jq flags to produce a count of players based on the length of the original JSON key used. However, I've found that while things like TF2 will produce the proper value, the Minecraft plugin will have an extra user online that is empty. See example below:
"players": [
{
"id": "81eeda65-9002-4f0d-9d3f-b4872e2a2042",
"name": "iamjack1221"
},
{}
]
- Re-worked if statement for Minecraft servers to not subtract 1 from the length of the player count.
|
The brach you are raiseing with is very different from the current version of LinuxGSM |
|
the functions directory was moved to modules a very long time ago. You will need to pull the latest develop branch and re raise this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current iteration of this command always produces a value of 0 when running it on Minecraft servers. Not sure if there was an issue with Gamedig on a previous version but that matter seems to be resolved with the version I am using which is 5.1.4. This request simply removes the 'if' statement related to Minecraft servers so it can use the same command as all the other servers.
Fixes #4724
Type of change
Checklist
PR will not be merged until all steps are complete.
developbranch as its base.Documentation
If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.
Thank you for your Pull Request!