Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(newserver): soulmask #4590

Merged
merged 22 commits into from
Jun 16, 2024

Conversation

intel44
Copy link
Contributor

@intel44 intel44 commented Jun 10, 2024

Description

Adding server compatibility for soulmask : https://store.steampowered.com/app/2646460/Soulmask/

AppID : 3017300

Based on documentation :

Specific development : The game uses telnet as server manager. In order to stop the game server cleanly, an attempt is made to save the world before stopping the server. If telnet fails, the server is killed via tmux (standard).
A similar process existed for 7 Days to Die. Development was based on what already existed.

Fixes #4587

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked if documentation needs updating.

Documentation

PR : GameServerManagers/LinuxGSM-Docs#106

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

@intel44 intel44 force-pushed the 4587-add_soulmask_server branch from da27632 to 6274284 Compare June 11, 2024 19:27
@intel44 intel44 force-pushed the 4587-add_soulmask_server branch from 6274284 to 39fb0e3 Compare June 11, 2024 19:47
@intel44 intel44 marked this pull request as ready for review June 11, 2024 20:24
@dgibbs64 dgibbs64 added this to the v24.3.0 milestone Jun 15, 2024
@dgibbs64
Copy link
Member

currently testing. Confirmed crashing on ubuntu 24.04

@dgibbs64 dgibbs64 force-pushed the 4587-add_soulmask_server branch from 1c0ca6a to 4668981 Compare June 16, 2024 00:41
@dgibbs64 dgibbs64 linked an issue Jun 16, 2024 that may be closed by this pull request
2 tasks
@dgibbs64 dgibbs64 merged commit 493a3a8 into GameServerManagers:develop Jun 16, 2024
3 checks passed
@heusmich
Copy link

Hi,

Is there already a release date for the Soulmask server in LinuxGSM?

@intel44
Copy link
Contributor Author

intel44 commented Jun 20, 2024

Hi,

Is there already a release date for the Soulmask server in LinuxGSM?

It's already merged in develop branch. You can deploy it like this using env variable : (or wait for new release)

As usual, Download linuxgsm.sh

curl -Lo linuxgsm.sh https://linuxgsm.sh && chmod +x linuxgsm.sh

Set these environement variables in your current terminal in order to use the development branch :

export LGSM_GITHUBBRANCH=develop

And launch server installation as usual with lunixgsm.sh :

./linuxgsm.sh smserver

Don't hesitate to give me any feedback !
@heusmich

@intel44
Copy link
Contributor Author

intel44 commented Jun 20, 2024

@dgibbs64 I'd like to take this opportunity to thank you for his quick adjustment and validation

I've been using lgsm for over 8 years now, and having created a similar library in bash several years ago on the professional side in order to centralise our processes, I can tell you that it's a pleasure to learn and discover on the dev side !

I wish you all the best for the future, and our paths should cross again depending on the games that come along 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Server Request]: Soulmask
3 participants