Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The names of our sets often contain colons - this should fix parser errors we were seeing. I have also added support for colons to object names.
I guess I have two questions about this:
Maybe those two remaining questions boil down to: Do we want object names in gaffer to be more restricted than they currently are? "sphere*&|" is a perfectly valid name at the moment, but it feels like we should only allow [_a-zA-Z0-9][_a-zA-Z0-9:]* maybe? Having a convention like that would make it easier to keep the parser code in sync, I guess...