Skip to content

Comments

Feat/improve trees gen#57

Open
izharus wants to merge 9 commits intoGaelmare:1.20.xfrom
izharus:feat/improve-trees-gen
Open

Feat/improve trees gen#57
izharus wants to merge 9 commits intoGaelmare:1.20.xfrom
izharus:feat/improve-trees-gen

Conversation

@izharus
Copy link

@izharus izharus commented Dec 27, 2024

feat/improve-trees-gen

The growth logic for most trees has been reworked to better match the appearance of generated trees in the world (Group A) and to ensure some trees resemble their real-world counterparts more closely (Group B).

Group A

  • Birch
  • Blackwood
  • Chestnut
  • Douglas Fir
  • Hickory
  • Maple
  • Rosewood
  • Sycamore
  • Aspen

Group B

  • Pine: Completely redesigned its appearance to better resemble a pine tree.
  • Spruce: Minor cosmetic improvements.

Trees Left Untouched:

  • Ash
  • White Cedar
  • Willow
  • Sequoia
  • Kapok

Let me know if there’s anything that needs further adjustments or if you’d like to revert any of the changes.

@izharus izharus changed the base branch from master to 1.20.x December 27, 2024 00:43
@Gaelmare
Copy link
Owner

Gaelmare commented Dec 27, 2024 via email

@izharus izharus changed the title Feat/improve trees gen [WIP] Feat/improve trees gen Dec 27, 2024
@izharus izharus force-pushed the feat/improve-trees-gen branch from 31eed9e to 3296847 Compare December 27, 2024 06:38
@izharus izharus force-pushed the feat/improve-trees-gen branch from 3296847 to 371b605 Compare December 27, 2024 08:29
@izharus
Copy link
Author

izharus commented Dec 27, 2024

You are correct, I mistakenly specified the wrong base branch, but it seems I fixed this error even before your message.
However, during additional testing, I discovered other issues, so:

  • I reverted the changes for Sequoia and Kapok—it's better to move them to a separate PR.
  • I stopped using the parameter smother==2—it turns out it can cause rare bugs in leaves. I will create an issue later with an example involving acacias.
  • I generated JoCodes for pine.

@izharus izharus changed the title [WIP] Feat/improve trees gen Feat/improve trees gen Dec 27, 2024
@Gaelmare
Copy link
Owner

I'm finally getting around to merging this, thanks!

@Gaelmare
Copy link
Owner

After testing, I see two issues. Old growth vanilla TFC trees like Douglas Fir and Willow are still generating, and I can't find mangrove.

Let me know if you think these were caused by this PR?

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants