-
Notifications
You must be signed in to change notification settings - Fork 38
Fix crash when closing Kama GUI equipped in bauble slot #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Does this also fix GTNewHorizons/GT-New-Horizons-Modpack#22417 |
|
I just tested the scenario where the player dies with the GUI of the kama or cloak open, since based on the stack traces posted on the linked issues, this seems to be the triggering factor. For the cape item, this cannot be reproduced in the latest version of the mod. For the kama item, this can be reproduced in the latest version of the mod, but the change this PR introduces seems to have fixed it as well. |
wlhlm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic change looks good, but both methods could be refactored with a switch expression.
wlhlm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it when a PR fixes three issues at once!
Fixes GTNewHorizons/GT-New-Horizons-Modpack#22900
Fixes GTNewHorizons/GT-New-Horizons-Modpack#22417
Fixes GTNewHorizons/GT-New-Horizons-Modpack#21562
Adds an additional bauble slot selector based on the GUI ID to correctly switch between using the
beltorcapeslots.