Skip to content

Conversation

@devpikachu
Copy link
Contributor

@devpikachu devpikachu commented Dec 28, 2025

Fixes GTNewHorizons/GT-New-Horizons-Modpack#22900
Fixes GTNewHorizons/GT-New-Horizons-Modpack#22417
Fixes GTNewHorizons/GT-New-Horizons-Modpack#21562

Adds an additional bauble slot selector based on the GUI ID to correctly switch between using the belt or cape slots.

@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Dec 28, 2025
@PLASMAchicken
Copy link
Member

Does this also fix GTNewHorizons/GT-New-Horizons-Modpack#22417
and GTNewHorizons/GT-New-Horizons-Modpack#21562 ? It seems to be related

@devpikachu
Copy link
Contributor Author

I just tested the scenario where the player dies with the GUI of the kama or cloak open, since based on the stack traces posted on the linked issues, this seems to be the triggering factor.

For the cape item, this cannot be reproduced in the latest version of the mod.

For the kama item, this can be reproduced in the latest version of the mod, but the change this PR introduces seems to have fixed it as well.

@devpikachu devpikachu changed the title Fix crash when closing Kama in bauble slot Fix crash when closing Kama GUI equipped in bauble slot Dec 29, 2025
Copy link
Member

@wlhlm wlhlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic change looks good, but both methods could be refactored with a switch expression.

@Dream-Master Dream-Master requested a review from wlhlm January 8, 2026 08:04
Copy link
Member

@wlhlm wlhlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it when a PR fixes three issues at once!

@UltraProdigy UltraProdigy merged commit 6f07332 into GTNewHorizons:master Jan 11, 2026
1 check passed
@UltraProdigy UltraProdigy added bugfix and removed 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta labels Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

5 participants